From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 29 Feb 2024 10:47:18 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rfd0Y-00FH6o-27 for lore@lore.pengutronix.de; Thu, 29 Feb 2024 10:47:18 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rfd0X-0004r7-SW for lore@pengutronix.de; Thu, 29 Feb 2024 10:47:18 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JpMmH5JD27qhmev62WRdibLk2sPITEiQHYhSiGT4Lso=; b=p5um1AwiVOxLAeEafnmzxCAUTC AMjt5TyBzT6oiZquAFjnMeomh9MF8Q+FG00rzEc+DfMd3jnpZ5+LOUgtVudOIHq2uZ2ZtwPJUqO2Z UEfvEPwgpGPSDyjBE8A5tBDsPOxqy7r4QLbe1UYd2Kojr9xklVCxBTYY3erY1tLg1hSK+wmxdI6rz /Nh3mDfx6gq0vD/5fOwijwrue79ZVjrP4OGN0Gu7Psv7nnIRM23Uk23Vg5OHyPjK8nGarQPWGOVTv 1FBjaTFxqC4Fbq8QJSYiHpgiPCWKkaA6iLGuZu18+D8xbDhhWksHCLFlQdK/tjPdMyyB80f7ZFmZt Y/1G+izQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfd01-0000000CztQ-1YXW; Thu, 29 Feb 2024 09:46:45 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfczy-0000000Czsy-1hNR for barebox@lists.infradead.org; Thu, 29 Feb 2024 09:46:43 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1rfczx-0004g0-3d; Thu, 29 Feb 2024 10:46:41 +0100 Message-ID: Date: Thu, 29 Feb 2024 10:46:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Marco Felsch Cc: barebox@lists.infradead.org References: <20240228180319.2739412-1-a.fatoum@pengutronix.de> <20240229091020.6fdnglwbla75hpn3@pengutronix.de> <20240229093324.by6gutzs6g3bgknz@pengutronix.de> From: Ahmad Fatoum In-Reply-To: <20240229093324.by6gutzs6g3bgknz@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240229_014642_480675_7109B04D X-CRM114-Status: GOOD ( 17.45 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.1 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH master] optee: don't warn about missing OP-TEE header X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) On 29.02.24 10:33, Marco Felsch wrote: > On 24-02-29, Ahmad Fatoum wrote: >> hdr is a valid pointer for me, but it doesn't point at a header, which causes >> me to get an error message. > > Yes, I have noticed the code path for non-pbl part as well now :/ > > I was thinking about: > > if (hdr->magic == 0) > return -EINVAL; > > but this is not far awways from you change. Therefore: This would assume that DRAM is zero-initialized after POR, which isn't given. > > Reviewed-by: Marco Felsch > > PS: Could you please fix the silent check as well by using IS_ERR_OR_NULL()? I will send a separate patch for that, so this can be picked up as-is. Cheers, Ahmad > > Regards, > Marco > >> >> Thanks, >> Ahmad >> >>> >>> Regards, >>> Marco >>> >>>> >>>> if (hdr->magic != OPTEE_MAGIC) { >>>> - pr_err("Invalid header magic 0x%08x, expected 0x%08x\n", >>>> - hdr->magic, OPTEE_MAGIC); >>>> + pr_debug("Invalid header magic 0x%08x, expected 0x%08x\n", >>>> + hdr->magic, OPTEE_MAGIC); >>>> return -EINVAL; >>>> } >>>> >>>> -- >>>> 2.39.2 >>>> >>>> >>> >> >> -- >> Pengutronix e.K. | | >> Steuerwalder Str. 21 | http://www.pengutronix.de/ | >> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | >> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | >> >> > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |