From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mout.gmx.net ([212.227.15.19]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gUXh5-0001HG-QP for barebox@lists.infradead.org; Wed, 05 Dec 2018 13:58:29 +0000 References: <20181127091935.2992-1-o.rempel@pengutronix.de> <20181127091935.2992-9-o.rempel@pengutronix.de> <20181205115031.d90c15ad4703eba8f8be818d@gmail.com> From: Oleksij Rempel Message-ID: Date: Wed, 5 Dec 2018 14:58:12 +0100 MIME-Version: 1.0 In-Reply-To: <20181205115031.d90c15ad4703eba8f8be818d@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6611781104998215868==" Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH v3 08/10] MIPS: port all mach* to multiimage To: Antony Pavlov , Oleksij Rempel Cc: barebox@lists.infradead.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============6611781104998215868== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dZjpvMlMdZHNzGmBM4H7Z7Pnv641CrOpS" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --dZjpvMlMdZHNzGmBM4H7Z7Pnv641CrOpS Content-Type: multipart/mixed; boundary="Lih3tBFEqGP93Y4VIVCDQxIAnJtP4ZwIL"; protected-headers="v1" From: Oleksij Rempel To: Antony Pavlov , Oleksij Rempel Cc: barebox@lists.infradead.org Message-ID: Subject: Re: [PATCH v3 08/10] MIPS: port all mach* to multiimage References: <20181127091935.2992-1-o.rempel@pengutronix.de> <20181127091935.2992-9-o.rempel@pengutronix.de> <20181205115031.d90c15ad4703eba8f8be818d@gmail.com> In-Reply-To: <20181205115031.d90c15ad4703eba8f8be818d@gmail.com> --Lih3tBFEqGP93Y4VIVCDQxIAnJtP4ZwIL Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Am 05.12.18 um 09:50 schrieb Antony Pavlov: > On Tue, 27 Nov 2018 10:19:33 +0100 > Oleksij Rempel wrote: >=20 >=20 > ... >=20 >> diff --git a/arch/mips/boards/8devices-lima/include/board/board_pbl_st= art.h b/arch/mips/boards/8devices-lima/lowlevel.S >> similarity index 78% >> rename from arch/mips/boards/8devices-lima/include/board/board_pbl_sta= rt.h >> rename to arch/mips/boards/8devices-lima/lowlevel.S >> index e95aa49256..a619747f39 100644 >> --- a/arch/mips/boards/8devices-lima/include/board/board_pbl_start.h >> +++ b/arch/mips/boards/8devices-lima/lowlevel.S >> @@ -15,51 +15,39 @@ >> * >> */ >> =20 >> -#include >> +#define BOARD_PBL_START start_8devices_lima >> + >> +#include >> +#include >> #include >> #include >> #include >> #include >> =20 >> - .macro board_pbl_start >> - .set push >> - .set noreorder >> +ENTRY_FUNCTION(BOARD_PBL_START) >> =20 >> mips_barebox_10h >> =20 >> - debug_ll_ar9344_init >> - >> - debug_ll_outc '1' >> + debug_ll_ath79_init >> =20 >=20 > I suppose there is a problem with simultaneous debug_ll support for AR9= 344 and AR9331 in one binary. > the Kconfig DEBUG_AR9331_UART and DEBUG_AR9344_UART options are mutuall= y exclusive. >=20 > Your approach makes it possible to build barebox binary image for AR933= 1 board with debug_ll code for AR9344 > and vice versa. yes, same issues as with most of DEBUG_LL related configurations in common/Kconfig. It is possible to misconfigure the DEBUG_LL for board or SoC. Currently I don't have a solution except of remove DEBUG_LL support completely from Kconfig for MIPS, or introduce some dynamic configuration, which is not related to this patch set. @Sascha? >> hornet_mips24k_cp0_setup >> - debug_ll_outc '2' >> =20 >> /* test if we are in the SRAM */ >> pbl_blt 0xbd000000 1f t8 >=20 > "if $pc < 0xbd000000 then jump to 1f" >=20 >> - debug_ll_outc '3' >> b skip_flash_test >> nop >> 1: >> /* test if we are in the flash */ >> pbl_blt 0xbf000000 skip_pll_ram_config t8 >=20 > "if $pc < 0xbf000000 then jump to skip_pll_ram_config" >=20 >=20 > The code checks that $pc is less than 0xbd000000 if true then the code = checks > that $pc is less than 0xbf000000. The second check is redundant! It is not a regression introduced by this patch, so it should be fixed separately. >=20 >> - debug_ll_outc '4' >> skip_flash_test: >> =20 >> pbl_qca4531_ddr2_550_550_init >> =20 >> - debug_ll_outc '5' >> /* Initialize caches... */ >> mips_cache_reset >> =20 >> /* ... and enable them */ >> dcache_enable >> skip_pll_ram_config: >> - debug_ll_outc '6' >> - debug_ll_outnl >> - >> - mips_nmon >> - >> - copy_to_link_location pbl_start >> =20 >> - .set pop >> - .endm >> +ENTRY_FUNCTION_END(BOARD_PBL_START, qca4531_8devices_lima) Did you tested this patches? --=20 Regards, Oleksij --Lih3tBFEqGP93Y4VIVCDQxIAnJtP4ZwIL-- --dZjpvMlMdZHNzGmBM4H7Z7Pnv641CrOpS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEpENFL0P3hvQ7p0DDdQOiSHVI77QFAlwH2XUACgkQdQOiSHVI 77SuTwf+NtQ7/wYJVyTtRvaEdoMDTvuLzKmkclae/pf0juwM8yNlsdrwrMEjCVcG 9fNrles6yxNyXNUSjplu3kIs4KCliHdimMI7FlGzZH9OM6PVxdrIerpGlfMd4hh0 BlT4oLbtRez2Yo0CT5QBLTJTbyixUJ0P6ZEFIDFpiqO33MRbqqfqV0lIBepBw1Lz y7jgir7FmJhilkMJAIzTX+QzKXYgQkOttdHuTYgTeLf98CU+S/IAxsHqCcPNWGT6 urMTjLXbO4TIm6/z9YDqti94fiCpSgsUC8Q1nc5SUBRkRRUvzqPnABqA14tw5NDo lPBLOecby813ayhgvwPoxT7k1/CEdQ== =nHZA -----END PGP SIGNATURE----- --dZjpvMlMdZHNzGmBM4H7Z7Pnv641CrOpS-- --===============6611781104998215868== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox --===============6611781104998215868==--