From: Daniel Schultz <d.schultz@phytec.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 3/3] drivers: mtd: nand: omap: Return stat value
Date: Fri, 23 Feb 2018 16:53:00 +0100 [thread overview]
Message-ID: <ebf7fb0b-4737-1196-3143-9683ace912dc@phytec.de> (raw)
In-Reply-To: <20180216075639.yenwl6sdlhqgvwqj@pengutronix.de>
On 02/16/2018 08:56 AM, Sascha Hauer wrote:
> On Thu, Feb 15, 2018 at 01:51:26PM +0100, Daniel Schultz wrote:
>> Hi Sascha,
>>
>>
>> On 01/30/2018 08:11 AM, Sascha Hauer wrote:
>>> On Mon, Jan 29, 2018 at 02:04:11PM +0100, Daniel Schultz wrote:
>>>> The read page function should return the total count of flipped bits,
>>>> otherwise the caller always thinks no bitflip occured.
>>>>
>>>> Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
>>>> ---
>>>> drivers/mtd/nand/nand_omap_gpmc.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/mtd/nand/nand_omap_gpmc.c b/drivers/mtd/nand/nand_omap_gpmc.c
>>>> index e18ce63..38f4960 100644
>>>> --- a/drivers/mtd/nand/nand_omap_gpmc.c
>>>> +++ b/drivers/mtd/nand/nand_omap_gpmc.c
>>>> @@ -712,7 +712,7 @@ static int omap_gpmc_read_page_bch_rom_mode(struct mtd_info *mtd,
>>>> else
>>>> mtd->ecc_stats.corrected += stat;
>>>> - return 0;
>>>> + return stat;
>>>> }
>>> I'm afraid this is not enough. read_page should return the maximum
>>> number of bitflips in any ECC step. You first have to change
>>> omap_correct_bch() so that it returns this number.
>> ahh, we worked on this problem a half year ago and it seems like three
>> patches are missing upstream:
>>
>> http://lists.infradead.org/pipermail/barebox/2017-June/030385.html
>> http://lists.infradead.org/pipermail/barebox/2017-June/030384.html
>> http://lists.infradead.org/pipermail/barebox/2017-June/030355.html
> Oh, I see. It seems I have either forgotten to merge them or I have
> waited for feedback. Could you create a series for all missing patches
> including your new patch and resend it, provided it works as expected of
> course?
Yes, I will do this as soon as I have time for it.
--
Mit freundlichen Grüßen,
With best regards,
Daniel Schultz
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-02-23 15:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-29 13:04 [PATCH 1/3] commands: ubi: ubiupdatevol: Reduce error code to 0 or 1 Daniel Schultz
2018-01-29 13:04 ` [PATCH 2/3] ARM: configs: am335x_defconfig: Reorder configs Daniel Schultz
2018-01-29 13:04 ` [PATCH 3/3] drivers: mtd: nand: omap: Return stat value Daniel Schultz
2018-01-30 7:11 ` Sascha Hauer
2018-02-15 12:51 ` Daniel Schultz
2018-02-16 7:56 ` Sascha Hauer
2018-02-23 15:53 ` Daniel Schultz [this message]
2018-01-30 7:05 ` [PATCH 1/3] commands: ubi: ubiupdatevol: Reduce error code to 0 or 1 Sascha Hauer
2018-01-30 7:13 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebf7fb0b-4737-1196-3143-9683ace912dc@phytec.de \
--to=d.schultz@phytec.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox