Re: [PATCH master 2/7] nvmem: bsec: correct regmap's max_register

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hello Robin,

On 08.01.24 13:48, Robin van der Gracht wrote:
> On Mon, 8 Jan 2024 12:17:09 +0100
> Robin van der Gracht <robin@protonic.nl> wrote:
> 
> ...
>>>
>>> barebox@Linux Automation MC-1 board:/ ls -l /dev/stm32-bsec 
>>> crw-------            384 /dev/stm32-bsec  
>>
>> Thats more like it. I'll apply the full series and recheck.
> 
> This works as expected. Thanks.
> 
> Minor note:
> 
> As you mention in your patch notes:
> "struct regmap::max_register is in units of struct regmap::reg_stride"

Argh. I see now that my wording was ambiguous. I meant to say is that max_register
is a multiple of regmap::reg_stride, but one could understand the commit message
the other way...

> This used to be the value of the maximum register number (index).
> The doc in include/linux/regmap.h line 33 mentions 'index'. Maybe that
> needs some mentioning of stride as well..

regmap is expressive enough to support a scheme where register numbers
increase by 1, but values by 4. This would have been the proper way to
register the regmap. Alas, I didn't do it this way when I first added the
bsec driver, so we'll have to live with this.

> 
> Regardless:
> Tested-by: Robin van der Gracht <robin@protonic.nl>

Thanks. I just Cc'd you on a documentation patch.

Cheers,
Ahmad

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |