From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 28 Jun 2022 10:27:31 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1o66ZE-0002jJ-19 for lore@lore.pengutronix.de; Tue, 28 Jun 2022 10:27:31 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o66ZG-00013m-3o for lore@pengutronix.de; Tue, 28 Jun 2022 10:27:30 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2HQ0NQ0xrdca7NMCyI3GaWzdoVAbbqwmp5gKNeRO67U=; b=qjH19N20CCdAQ9pUdBm5zOMJ2O nGjDotVc1Texz0PchFaxXFp1N4S+AeKKB7mJAMaY2nWMM9wbhMn82BmBiH3bkti+AMnIIanUY+hZU wN559/9jtO90cU0jqngXpBVhfq1CHgDw+RFmT8Qc/neDZuNVnxUEOWK+shGzOiRlOb2113nxNOzI5 xGMupQUzNi6F4waqLvDVWYaf9pShZuwTgFfUO3dzEwZA98wmVSG0Uysi/Q1vq1B9nMNN6tnqsAJfR fb9ebJtg7Cg8ZepE1mXpxGlzc06/ImSxuTxIr3ektdu6naVGq9SqGkEWnTwkvbJuRr8lNCgIXJa82 mw5gi13Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o66Xi-005FYF-Ug; Tue, 28 Jun 2022 08:25:55 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o66V2-005EED-Ap for barebox@lists.infradead.org; Tue, 28 Jun 2022 08:23:10 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1o66Uw-0000G2-9P; Tue, 28 Jun 2022 10:23:02 +0200 Message-ID: Date: Tue, 28 Jun 2022 10:23:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Content-Language: en-US To: Alexander Shiyan , barebox@lists.infradead.org References: <20220628080414.28960-1-eagle.alexander923@gmail.com> From: Ahmad Fatoum In-Reply-To: <20220628080414.28960-1-eagle.alexander923@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220628_012308_434314_EA97844E X-CRM114-Status: GOOD ( 10.86 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-3.7 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH] serial: ns16550: Reuse 48MHz default clock definition for non-DT OMAP boards X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On 28.06.22 10:04, Alexander Shiyan wrote: > Signed-off-by: Alexander Shiyan Reviewed-by: Ahmad Fatoum > - if (!IS_ENABLED(CONFIG_OFDEVICE)) > + if (!IS_ENABLED(CONFIG_OFDEVICE) || !np) Nitpick: struct device_node *np = dev_of_node(dev); if (!np) is equivalent, but a bit less verbose. -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |