From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 02 Jul 2026 15:42:00 +0200 Received: from mx1.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::107]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wfHg0-00CHAa-0o for lore@lore.pengutronix.de; Thu, 02 Jul 2026 15:42:00 +0200 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by mx1.white.stw.pengutronix.de (Postfix) with ESMTPS id D247D20195E for ; Thu, 02 Jul 2026 15:41:59 +0200 (CEST) Authentication-Results: mx1.white.stw.pengutronix.de; dkim=pass header.d=lists.infradead.org header.s=bombadil.20210309 header.b=PUK3ZTIV; spf=pass (mx1.white.stw.pengutronix.de: domain of "barebox-bounces+lore=pengutronix.de@lists.infradead.org" designates 2607:7c80:54:3::133 as permitted sender) smtp.mailfrom="barebox-bounces+lore=pengutronix.de@lists.infradead.org"; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dJoyRjyALb6VpojRh8Ht09x2m5Yy1+V182G2A0n9Nx4=; b=PUK3ZTIV10CgzFUOtFK9UNvL4t IQRYSnX4vTvGFq8mpCRJOhNF5h1B/Fz1vDeZUQLj/E3FE1WkAJUsATMJvgWbbwGJH1cLJ3ZKJONYe KOSeys70xzmiUildtiHusr0FoXratv6sAkeEZdPKOB0DimZwYJNz+C+1qj7lYYAPkkycwTqPKFbDN 2klqmmdB6rFtqT8mas9tCYgEqek1iR9yZpWB/CkVHsgbu1uT87lKdWDk48IDiXx/+OkdEEWu8iRgb wfYhPE0KUXcmYnRoojfco7flPvrle0dCAGeTQlP0yhyfhCRgUIHYPiIRAwjxatq8beFR49SPXosFB aZSJUU9A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfHeg-00000004Xt9-48Wr; Thu, 02 Jul 2026 13:40:38 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfHed-00000004XrO-005k for barebox@lists.infradead.org; Thu, 02 Jul 2026 13:40:37 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1wfHea-0001T2-1y; Thu, 02 Jul 2026 15:40:32 +0200 Message-ID: Date: Thu, 2 Jul 2026 15:40:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] restart: fix restart handler by name selection To: Marco Felsch , barebox@lists.infradead.org References: <20260622172121.1736295-1-m.felsch@pengutronix.de> Content-Language: en-US, de-DE, de-BE From: Ahmad Fatoum In-Reply-To: <20260622172121.1736295-1-m.felsch@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260702_064035_041895_A11C9889 X-CRM114-Status: GOOD ( 20.86 ) X-Spam-Score: -1.9 (-) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hello, On 6/22/26 7:21 PM, Marco Felsch wrote: > Commit d20a9a455d8d ("restart: allow selecting restart handler by device > name") introduce a bug, while adding the support to select a restart > handler by d [...] Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a0a:edc0:2:b01:1d:0:0:104 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 DMARC_MISSING Missing DMARC policy X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-Rspamd-Queue-Id: D247D20195E X-Spamd-Result: default: False [-6.51 / 15.00]; BAYES_HAM(-3.00)[99.99%]; DWL_DNSWL_MED(-2.00)[infradead.org:dkim]; RCVD_DKIM_ARC_DNSWL_MED(-0.50)[]; R_DKIM_ALLOW(-0.20)[lists.infradead.org:s=bombadil.20210309]; RCVD_IN_DNSWL_MED(-0.20)[2607:7c80:54:3::133:from]; MAILLIST(-0.20)[mailman]; R_SPF_ALLOW(-0.20)[+mx:c]; MIME_GOOD(-0.10)[text/plain]; RCVD_IN_DNSWL_LOW(-0.10)[2a0a:edc0:0:900:1d::77:received]; HAS_LIST_UNSUB(-0.01)[]; FORWARDED(0.00)[barebox@lists.infradead.org]; RECEIVED_HELO_LOCALHOST(0.00)[]; FORGED_SENDER(0.00)[a.fatoum@pengutronix.de,barebox-bounces@lists.infradead.org]; DMARC_NA(0.00)[pengutronix.de]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_LAST(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2a0a:edc0:2:b01:1d::104:received]; FORGED_SENDER_FORWARDING(0.00)[]; FROM_NEQ_ENVFROM(0.00)[a.fatoum@pengutronix.de,barebox-bounces@lists.infradead.org]; FROM_HAS_DN(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; NEURAL_HAM(-0.00)[-1.000]; ASN(0.00)[asn:7247, ipnet:2607:7c80:54::/48, country:US]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_FROM(0.00)[lore=pengutronix.de]; DKIM_TRACE(0.00)[lists.infradead.org:+]; FORGED_SENDER_MAILLIST(0.00)[] X-Rspamd-Action: no action X-Stat-Signature: udb6njorn1ceise43ga5o34c9g61n9ad X-Rspamd-Server: mx1 Hello, On 6/22/26 7:21 PM, Marco Felsch wrote: > Commit d20a9a455d8d ("restart: allow selecting restart handler by device > name") introduce a bug, while adding the support to select a restart > handler by device name. > > The list_for_each_entry() loop should sort out all restart handler which > don't match the user requested restart handler. Instead all restart > handlers which don't have a device associated are honored as well > because the if condition is always 0 in this case. > > Split the if to fix this and add a helper variable to make the code more > readable. > > Fixes: d20a9a455d8d ("restart: allow selecting restart handler by device name") > Signed-off-by: Marco Felsch Why do we have restart handlers without a device name? Cheers, Ahmad > --- > common/restart.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/common/restart.c b/common/restart.c > index 391d7bd3773c..85519912170d 100644 > --- a/common/restart.c > +++ b/common/restart.c > @@ -117,8 +117,13 @@ struct restart_handler *restart_handler_get_by_name(const char *name, int flags) > > list_for_each_entry(tmp, &restart_handler_list, list) { > if (name) { > - if ((tmp->name && strcmp(name, tmp->name)) && > - (tmp->dev && strcmp(name, dev_name(tmp->dev)))) > + bool found = false; > + > + if (tmp->name && !strcmp(name, tmp->name)) > + found = true; > + if (tmp->dev && !strcmp(name, dev_name(tmp->dev))) > + found = true; > + if (!found) > continue; > } > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |