From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 26 Sep 2024 07:38:58 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sthDN-002slP-12 for lore@lore.pengutronix.de; Thu, 26 Sep 2024 07:38:58 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sthDN-0004mO-QD for lore@pengutronix.de; Thu, 26 Sep 2024 07:38:58 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mkAiban+8q/CmTG6HlBBWBu5yhOqMaq4mxWqNqhn6ys=; b=Bvev0rV/aNmwfjaZwcjUWlOp9U cMrooG2Cv/7x9YDWxmKBGU9/virqFDs9NP/Kn5oqVK0x8t+/X57oATYk5qwOdFdZn9LrGulDh/Mm5 0kbMhd1vtvu5NnCyOwmHefTv9Ad2STQ2EKfHFKVD26OlXaSwpaLBlRCiAqNaH/4mXvSQCkXCH47Jg nKe9WZVEdnUVJWDaGREfkgK5PfNdHzrKUGtIMiQpZQRluToROPVWjUWji0PXjmjyhVAlhJZB8oLvp oLoa3q2jNHpNilmf+5Iyx2yxX3lWHegh0WzUUo1irnOJvVhPeFs9eLYiwHyQlb9G2mtq1vK4TScLb T5/QAqDw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sthCt-00000007FYY-3h0a; Thu, 26 Sep 2024 05:38:27 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sthCq-00000007FYC-2lwK for barebox@lists.infradead.org; Thu, 26 Sep 2024 05:38:25 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1sthCp-0004U1-7S; Thu, 26 Sep 2024 07:38:23 +0200 Message-ID: Date: Thu, 26 Sep 2024 07:38:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sascha Hauer , "open list:BAREBOX" References: <20240925-graphics-v1-0-f1fe5d2cceec@pengutronix.de> <20240925-graphics-v1-4-f1fe5d2cceec@pengutronix.de> Content-Language: en-US From: Ahmad Fatoum In-Reply-To: <20240925-graphics-v1-4-f1fe5d2cceec@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240925_223824_733354_F073E2F8 X-CRM114-Status: GOOD ( 18.48 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.0 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH 4/5] fbconsole: make background pixels transparent X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) On 25.09.24 16:34, Sascha Hauer wrote: > When we have a background image we want the background to actually shine > through, so set the alpha value of the background to transparent and not > opaque. > > Signed-off-by: Sascha Hauer Reviewed-by: Ahmad Fatoum I wonder if this could cause a slow down for framebuffers with no alpha channel, because it will read the framebuffer on every pixel write for alpha blending purposes, even if ultimately unnecessary? > --- > drivers/video/fbconsole.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbconsole.c b/drivers/video/fbconsole.c > index cec1afec56..d3615bc07f 100644 > --- a/drivers/video/fbconsole.c > +++ b/drivers/video/fbconsole.c > @@ -139,7 +139,7 @@ static void drawchar(struct fbc_priv *priv, int x, int y, int c) > color = gu_rgb_to_pixel(priv->fb, rgb->r, rgb->g, rgb->b, 0xff); > > rgb = &colors[bgcolor]; > - bgcolor = gu_rgb_to_pixel(priv->fb, rgb->r, rgb->g, rgb->b, 0xff); > + bgcolor = gu_rgb_to_pixel(priv->fb, rgb->r, rgb->g, rgb->b, 0x0); > > for (i = 0; i < priv->font->height; i++) { > uint8_t mask = 0x80; > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |