From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 11 Mar 2024 14:27:48 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rjfgy-0017W9-1z for lore@lore.pengutronix.de; Mon, 11 Mar 2024 14:27:48 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rjfgx-0002PC-VS for lore@pengutronix.de; Mon, 11 Mar 2024 14:27:48 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7DEZMOec4ivFIPmR98xFTQOrPH/ZL+r+XnAGKkrCReQ=; b=xMb0Njp30fQJOBXSgqylBqgAZd PltxEIwKhs+3Gs/AGFCQEoNhk0+I4YdQ21m1MYYozMbs7lfrYvKBbJ+zLZXy/IVjPkAvFniqw9ifp d3jr2+8cW4JsXBkaId2ToB3F+jRJIf2c/pzTE1xtW3uOjbxXOyfZe0Qc7IBoQvHULKaxaGjNNIsM4 dvxiV7xz0JugKZ1TYnv0smU7SS+yaHLi/iouUOsURa9/DBI5ZsZhAMR8elwizj/JkJ4/arDiP71jC KNIVvhDoxLW4OCnNFBIfNr+dL0h6FPMl7p7/b8baTXR0j3iLBFwuc8rDcqkSXdhPyG5enQoLKMYBa oBzlLZQg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rjfgI-00000001c0k-3pKn; Mon, 11 Mar 2024 13:27:06 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rjffR-00000001bkr-3OWh for barebox@lists.infradead.org; Mon, 11 Mar 2024 13:27:02 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[IPV6:::1]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1rjffA-0000wO-3a; Mon, 11 Mar 2024 14:25:56 +0100 Message-ID: Date: Mon, 11 Mar 2024 14:25:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US, de-DE To: Ahmad Fatoum , Sascha Hauer , BAREBOX References: <20240311-karo-imx8mp-som-board-upstreaming-v1-0-7c77f9ba02e5@pengutronix.de> <20240311-karo-imx8mp-som-board-upstreaming-v1-5-7c77f9ba02e5@pengutronix.de> From: Stefan Kerkmann In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240311_062614_082132_C49CB4D9 X-CRM114-Status: GOOD ( 12.51 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.9 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH 5/6] arm: dts: karo: add karo imx8mp-karo-qsxp-qsbase4 X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) Hello Ahmad, On 11.03.24 11:05, Ahmad Fatoum wrote: > On 11.03.24 10:10, Stefan Kerkmann wrote: >> +/dts-v1/; >> + >> +#include "imx8mp-karo-qsxp-ml81.dts" >> + >> +&{/} { > > While not wrong, this is unnecessary. We know that there is a / already. > Ack. >> + model = "Ka-Ro electronics QSXP-ML81-QSBASE4 (NXP i.MX8MP) Board"; >> + compatible = "karo,imx8mp-qsxp-ml81-qsbase4", "karo,imx8mp-qsxp-ml81", "fsl,imx8mp"; > > Ok, this confuses me. I thought QSXP is the SoM. What's ML81? The official part number from karo is `QSXP-ML81`, it is just not mentioned upfront on their product page - but you'll see it under `Varianten` at https://www.karo-electronics.de/qsxp#c12158. Therefore I vote to keep the `ml81` part. > > >> +&usdhc2 { >> + status = "disabled"; >> +}; > > Nitpick: Should be disabled in SoM, as it requires outside hardware to be functional. > Ack. >> + >> +&iomuxc { >> + pinctrl_eqos: eqosgrp { >> + fsl,pins = < >> + MX8MP_IOMUXC_SAI2_RXC__GPIO4_IO22 0x140 /* PHY reset */ >> + MX8MP_IOMUXC_ENET_MDC__ENET_QOS_MDC 0x142 >> + MX8MP_IOMUXC_ENET_MDIO__ENET_QOS_MDIO 0x142 >> + MX8MP_IOMUXC_ENET_TXC__CCM_ENET_QOS_CLOCK_GENERATE_TX_CLK 0x40000016 >> + MX8MP_IOMUXC_ENET_TD0__ENET_QOS_RGMII_TD0 0x016 >> + MX8MP_IOMUXC_ENET_TD1__ENET_QOS_RGMII_TD1 0x016 >> + MX8MP_IOMUXC_ENET_TD2__ENET_QOS_RGMII_TD2 0x016 >> + MX8MP_IOMUXC_ENET_TD3__ENET_QOS_RGMII_TD3 0x016 >> + MX8MP_IOMUXC_ENET_TX_CTL__ENET_QOS_RGMII_TX_CTL 0x016 >> + MX8MP_IOMUXC_ENET_RD0__ENET_QOS_RGMII_RD0 0x110 /* MODE0 */ >> + MX8MP_IOMUXC_ENET_RD1__ENET_QOS_RGMII_RD1 0x150 /* MODE1 */ >> + MX8MP_IOMUXC_ENET_RD2__ENET_QOS_RGMII_RD2 0x150 /* MODE2 */ >> + MX8MP_IOMUXC_ENET_RD3__ENET_QOS_RGMII_RD3 0x150 /* MODE3 */ >> + MX8MP_IOMUXC_ENET_RXC__CCM_ENET_QOS_CLOCK_GENERATE_RX_CLK 0x156 /* PHYAD2 */ >> + MX8MP_IOMUXC_ENET_RX_CTL__ENET_QOS_RGMII_RX_CTL 0x000 /* CLK125_EN */ >> + MX8MP_IOMUXC_GPIO1_IO00__CCM_ENET_PHY_REF_CLK_ROOT 0x110 /* LED_MODE */ >> + >; >> + }; >> + >> + pinctrl_eqos_sleep: eqos-sleep-grp { >> + fsl,pins = < >> + MX8MP_IOMUXC_SAI2_RXC__GPIO4_IO22 0x120 >> + MX8MP_IOMUXC_ENET_MDC__GPIO1_IO16 0x120 >> + MX8MP_IOMUXC_ENET_MDIO__GPIO1_IO17 0x120 >> + MX8MP_IOMUXC_ENET_TXC__GPIO1_IO23 0x120 >> + MX8MP_IOMUXC_ENET_TD0__GPIO1_IO21 0x120 >> + MX8MP_IOMUXC_ENET_TD1__GPIO1_IO20 0x120 >> + MX8MP_IOMUXC_ENET_TD2__GPIO1_IO19 0x120 >> + MX8MP_IOMUXC_ENET_TD3__GPIO1_IO18 0x120 >> + MX8MP_IOMUXC_ENET_TX_CTL__GPIO1_IO22 0x120 >> + MX8MP_IOMUXC_ENET_RD0__GPIO1_IO26 0x120 >> + MX8MP_IOMUXC_ENET_RD1__GPIO1_IO27 0x120 >> + MX8MP_IOMUXC_ENET_RD2__GPIO1_IO28 0x120 >> + MX8MP_IOMUXC_ENET_RD3__GPIO1_IO29 0x120 >> + MX8MP_IOMUXC_ENET_RXC__GPIO1_IO25 0x120 >> + MX8MP_IOMUXC_ENET_RX_CTL__GPIO1_IO24 0x120 >> + MX8MP_IOMUXC_GPIO1_IO00__GPIO1_IO00 0x120 >> + >; >> + }; >> +}; >> > -- Pengutronix e.K. | Stefan Kerkmann | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-128 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |