Re: [PATCH 12/12] PWM: add support for STM32

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hello,

On 3/31/20 8:41 AM, Sascha Hauer wrote:
>> +		pwm1 = &{/soc/timer@44000000/pwm};
>> +		pwm2 = &{/soc/timer@40000000/pwm};
>> +		pwm3 = &{/soc/timer@40001000/pwm};
>> +		pwm4 = &{/soc/timer@40002000/pwm};
>> +		pwm5 = &{/soc/timer@40003000/pwm};
>> +		pwm8 = &{/soc/timer@44001000/pwm};
>> +		pwm12 = &{/soc/timer@40006000/pwm};
>> +		pwm13 = &{/soc/timer@40007000/pwm};
>> +		pwm14 = &{/soc/timer@40008000/pwm};
>> +		pwm15 = &{/soc/timer@44006000/pwm};
>> +		pwm16 = &{/soc/timer@44007000/pwm};
>> +		pwm17 = &{/soc/timer@44008000/pwm};
> 
> The other aliases start counting at 0. Why not the PWMs?

I named them to match the SoC data sheet,

The final device names are e.g. pwm12ch2, corresponding to TIM12_CH2
in the SoC datasheet. It's IMO the best user experience, because otherwise
you'll always have to look at the aliases in barebox to determine,
which PWM corresponds to what's printed in the schematics.

Cheers
Amad
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox