Hello Sascha,

thanks for picking up the first three patches
On Tue, Mar 04, 2025 at 10:15:13AM +0100, Sascha Hauer wrote:
> On Sat, Mar 01, 2025 at 05:36:17PM +0100, Uwe Kleine-König wrote:
> > this is the result of my quick effort to make barebox run on QNAP's
> > ts-433 4bay NAS. The first 3 patches are IMHO fine to go in. The last
> > one adds the new machine. As writting in the commit log the NAS boots
> > with the resulting image, but neither network nor eMMC work.
> > 
> > I also tried adding
> > 
> > 	writel(RK_SETBITS(0x50), 0xfdc20140)
> > 
> > in lowlevel.c, but that didn't make a difference. I'm open for other
> > ideas about what bit is missing.
> 
> dts/src/arm64/rockchip/rk3568-qnap-ts433.dts lacks the pinctrl nodes for
> the sdhci controller. It might be that it works when booting from eMMC,
> but not when booting from USB.

When I add pinctrl info like that:

diff --git a/dts/src/arm64/rockchip/rk3568-qnap-ts433.dts b/dts/src/arm64/rockchip/rk3568-qnap-ts433.dts
index e601d9271ba8..b65f2412023a 100644
--- a/dts/src/arm64/rockchip/rk3568-qnap-ts433.dts
+++ b/dts/src/arm64/rockchip/rk3568-qnap-ts433.dts
@@ -567,6 +567,8 @@ &sdhci {
 	bus-width = <8>;
 	max-frequency = <200000000>;
 	non-removable;
+	pinctrl-names = "default";
+	pinctrl-0 = <&emmc_bus8 &emmc_clk &emmc_cmd &emmc_datastrobe>;
 	status = "okay";
 };

I get an error message when the driver probes (see below).

Enabling deep probe (which was an idea from #barebox) didn't change
anything here.

> No idea for networking though.

With rtl8169 driver disabled the internal eth driver probes successfully
(didn't work out the details, with both enabled I get 
	ERROR: register_device: already registered eth
	ERROR: eqos-rockchip fe2a0000.ethernet@fe2a0000.of: probe failed: Invalid argument
) the full boot log is:

	barebox 2025.02.0-00004-g1ec0faa7cbbb-dirty #9 Mon Mar 17 17:29:30 CET 2025


	Board: Qnap TS-433-4G NAS System 4-Bay
	deep-probe: supported due to qnap,ts433
	rockchip-dmc memory-controller.of: Detected memory size: 0x100000000
	netconsole: registered as netconsole-1
	arm-scmi firmware:scmi.of: SCMI Protocol v2.0 'rockchip:' Firmware version 0x0
	psci psci.of: detected version 1.1
	xHCI xHCI0: USB XHCI 1.10
	ehci fd800000.usb@fd800000.of: USB EHCI 1.00
	ehci fd880000.usb@fd880000.of: USB EHCI 1.00
	rk808 rk8090: chip id: 0x8090
	rk3568-dwcmshc-sdhci fe310000.mmc@fe310000.of: registered as mmc0
	ERROR: rk3568-dwcmshc-sdhci fe310000.mmc@fe310000.of: SDHCI timeout while waiting for idle
	WARNING: mmc0: Card's startup fails with -16
	phy6: lane number 0, val 1
	phy6: lane number 1, val 2
	phy6: bifurcation enabled
	mdio_bus: miibus0: probed
	malloc space: 0xafd00000 -> 0xefcfffff (size 1 GiB)
	environment load /dev/env0: No such file or directory
	Maybe you have to create the partition.

	Hit any to stop autoboot:    3
	eth0: 1000Mbps full duplex link detected
	barebox@QNAP TS-433:/ ifup eth0
	WARNING: eth0: No MAC address set. Using random address 22:e8:c9:ad:3e:45
	T T T T T T T T T T T T T T T T T T T T ifup: Connection timed out

I guess the next step is to try 2nd stage booting with U-Boot.

Best regards
Uwe