On Tue, Mar 18, 2025 at 09:24:35AM +0100, Ahmad Fatoum wrote: > For MBR and GPT, barebox creates links to the partitions, so they can be > referenced both by index and partition label. > > Failing to create a link is not an error, but results in a warning > message. The current message claims that the link was pointing at the > parent block device's cdev, but it actually was pointing at the child > partition. Fix that. > > Reported-by: Uwe Kleine-König > Signed-off-by: Ahmad Fatoum > --- > common/partitions.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/common/partitions.c b/common/partitions.c > index 7562536cf9b8..bc90f51f6112 100644 > --- a/common/partitions.c > +++ b/common/partitions.c > @@ -63,7 +63,7 @@ static int register_one_partition(struct block_device *blk, struct partition *pa > ret = devfs_create_link(cdev, partition_name); > if (ret) > dev_warn(blk->dev, "Failed to create link from %s to %s\n", > - partition_name, blk->cdev.name); > + partition_name, cdev->name); This improves the error messages on my ts433 from WARNING: mmc0: Failed to create link from mmc0.primary to mmc0 WARNING: mmc0: Failed to create link from mmc0.primary to mmc0 WARNING: mmc0: Failed to create link from mmc0.primary to mmc0 WARNING: mmc0: Failed to create link from mmc0.primary to mmc0 WARNING: mmc0: Failed to create link from mmc0.primary to mmc0 to WARNING: mmc0: Failed to create link from mmc0.primary to mmc0.2 WARNING: mmc0: Failed to create link from mmc0.primary to mmc0.3 WARNING: mmc0: Failed to create link from mmc0.primary to mmc0.4 WARNING: mmc0: Failed to create link from mmc0.primary to mmc0.5 WARNING: mmc0: Failed to create link from mmc0.primary to mmc0.6 I still don't understand why barebox intends to create mmc0.primary for all these partitions, but still it's an obviously right improvement. Acked-by: Uwe Kleine-König Best regards and thanks Uwe