From: "Uwe Kleine-König" <uwe@kleine-koenig.org>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH master] linux/iopoll: fix inverted condition in read_poll_timeout
Date: Mon, 28 Apr 2025 09:29:40 +0200 [thread overview]
Message-ID: <phxkokwkn7utkoqksvmxtnp4nrazlz5g25kyu55w3s6yephumc@zyvdy77os4ac> (raw)
In-Reply-To: <20250426081415.3553913-1-a.fatoum@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 784 bytes --]
Hello Ahmad,
On Sat, Apr 26, 2025 at 10:14:15AM +0200, Ahmad Fatoum wrote:
> If there is no timeout, we wait indefinitely and don't care for the
> initial time. A fixup to silence a warning because of multiplication in
> boolean context added an explicit comparison and this ended up omitting
> get_time_ns() in the wrong case.
>
> Flip it to fix, among others, MDIO on RK3568.
>
> Fixes: 554bbc479c09 ("include: linux/iopoll.h: add optional PBL support")
> Reported-by: Uwe Kleine-König <uwe@kleine-koenig.org>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
This indeed fixes networking for me. Thanks a lot for your patch.
Tested-by: Uwe Kleine-König <uwe@kleine-koenig.org>
Reviewed-by: Uwe Kleine-König <uwe@kleine-koenig.org>
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2025-04-28 7:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-26 8:14 Ahmad Fatoum
2025-04-28 7:29 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=phxkokwkn7utkoqksvmxtnp4nrazlz5g25kyu55w3s6yephumc@zyvdy77os4ac \
--to=uwe@kleine-koenig.org \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox