Re: [OSS-Tools] [PATCH dt-utils 1/4] treewide: add SPDX identifiers to files with GPL-2.0-or-later license

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hello,

On 30.03.21 15:30, Uwe Kleine-König wrote:
> Hello,
> 
> On Tue, Mar 30, 2021 at 01:22:26PM +0200, Ahmad Fatoum wrote:
>> On 30.03.21 13:08, Roland Hieber wrote:
>>> Uwe, could I get a Reviewed-by from you for these four patches? :-)
>>
>> We must still carry the full license texts in the project (cf. Linux
>> LICENSES/). This is missing here, no?
> 
> well, it depends on what you want to achieve. If you want to become SPDX
> conformant this is indeed necessary. IMHO the conversion from several
> different boilerplate license specifications to a single line is
> beneficial even if the full licenses are not (yet) in the project.

If the code says that the license terms need to be distributed along
with the software, you are violating the license terms, if you don't
abide by this. This is unrelated to SPDX-Conformance.

> So I don't regret having given my Review-tags.

Reviewing is fine, but before applying license text removal, the full
license texts need to be located in full somewhere in the source tree.

Cheers,
Ahmad

> 
> Best regards
> Uwe
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
OSS-Tools mailing list
OSS-Tools@pengutronix.de