Re: [OSS-Tools] [PATCH dt-utils 3/4] treewide: add SPDX identifier to files with Zlib license

["Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>]

[-- Attachment #1.1: Type: text/plain, Size: 1686 bytes --]

On Fri, Mar 26, 2021 at 10:06:46PM +0100, Roland Hieber wrote:
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
>  src/crc32.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/crc32.c b/src/crc32.c
> index 8d4dddcf6129..6d534c996050 100644
> --- a/src/crc32.c
> +++ b/src/crc32.c
> @@ -1,3 +1,4 @@
> +/* SPDX-License-Identifier: Zlib */
>  /*
>   * This file is derived from crc32.c from the zlib-1.1.3 distribution
>   * by Jean-loup Gailly and Mark Adler.
> @@ -5,7 +6,6 @@
>  
>  /* crc32.c -- compute the CRC-32 of a data stream
>   * Copyright (C) 1995-1998 Mark Adler
> - * For conditions of distribution and use, see copyright notice in zlib.h
>   */

Interesting hunk separation. I wonder if this is worth to be reported
to the git list because

diff --git a/src/crc32.c b/src/crc32.c
index 8d4dddcf6129..6d534c996050 100644
--- a/src/crc32.c
+++ b/src/crc32.c
@@ -1,11 +1,11 @@
+/* SPDX-License-Identifier: Zlib */
 /*
  * This file is derived from crc32.c from the zlib-1.1.3 distribution
  * by Jean-loup Gailly and Mark Adler.
  */
 
 /* crc32.c -- compute the CRC-32 of a data stream
  * Copyright (C) 1995-1998 Mark Adler
- * For conditions of distribution and use, see copyright notice in zlib.h
  */
 
 #include <stdint.h>

should be equivalent and isn't any longer. Or is it only me who
considers this obviously better?

Other than that:

Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 96 bytes --]

_______________________________________________
OSS-Tools mailing list
OSS-Tools@pengutronix.de