mailarchive of the pengutronix oss-tools mailing list
 help / color / mirror / Atom feed
From: Roland Hieber <rhi@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: oss-tools@pengutronix.de,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [OSS-Tools] [PATCH dt-utils 1/4] treewide: add SPDX identifiers to files with GPL-2.0-or-later license
Date: Wed, 31 Mar 2021 12:03:05 +0200	[thread overview]
Message-ID: <20210331100305.e4klllzxx4p7yhxo@pengutronix.de> (raw)
In-Reply-To: <3286977b-06a6-539d-f36f-35385671acca@pengutronix.de>

On Tue, Mar 30, 2021 at 07:31:24PM +0200, Ahmad Fatoum wrote:
> Hello Roland,
> 
> On 30.03.21 17:53, Roland Hieber wrote:
> > On Tue, Mar 30, 2021 at 03:50:19PM +0200, Ahmad Fatoum wrote:
> >> Hello,
> >>
> >> On 30.03.21 15:30, Uwe Kleine-König wrote:
> >>> Hello,
> >>>
> >>> On Tue, Mar 30, 2021 at 01:22:26PM +0200, Ahmad Fatoum wrote:
> >>>> On 30.03.21 13:08, Roland Hieber wrote:
> >>>>> Uwe, could I get a Reviewed-by from you for these four patches? :-)
> >>>>
> >>>> We must still carry the full license texts in the project (cf. Linux
> >>>> LICENSES/). This is missing here, no?
> >>>
> >>> well, it depends on what you want to achieve. If you want to become SPDX
> >>> conformant this is indeed necessary. IMHO the conversion from several
> >>> different boilerplate license specifications to a single line is
> >>> beneficial even if the full licenses are not (yet) in the project.
> >>
> >> If the code says that the license terms need to be distributed along
> >> with the software, you are violating the license terms, if you don't
> >> abide by this. This is unrelated to SPDX-Conformance.
> > 
> > Nothing in the license headers or in the GPL or in the Zlib license says
> > that we have to distribute the license text along with the source code.
> > On the contrary, there are even some versions of GPL license headers
> > that have a clause "if you didn't a license text along with the
> > software, write to the FSF at $ADDRESS".

Apparently I was wrong about this, see GPL Clause 1.

> If Zlib says "This notice may not be removed or altered from any
> source distribution.", I interpret this as meaning that we need to ship
> the full text as part of the source distribution and only a
> SPDX-License-Identifier that can be looked up on a website somewhere doesn't
> suffice.

Yes. Hmm. GPL says a similar thing in Clause 1 ("keep intact all the
notices that refer to this License and to the absence of any warranty").
When thinking about it, I'd rather keep the original comment headers
intact and only add an SPDX license tag, and I don't understand why
these notices were removed in Linux when Linux moved to SPDX
identifiers. I also didn't find any reasoning on this.

 - Roland

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
OSS-Tools mailing list
OSS-Tools@pengutronix.de

  reply	other threads:[~2021-03-31 10:03 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-26 21:06 Roland Hieber
2021-03-26 21:06 ` [OSS-Tools] [PATCH dt-utils 2/4] treewide: add SPDX identifiers to files with GPL-2.0-only license Roland Hieber
2021-03-30 12:50   ` Uwe Kleine-König
2021-03-26 21:06 ` [OSS-Tools] [PATCH dt-utils 3/4] treewide: add SPDX identifier to files with Zlib license Roland Hieber
2021-03-30 12:55   ` Uwe Kleine-König
2021-03-26 21:06 ` [OSS-Tools] [PATCH dt-utils 4/4] treewide: add SPDX identifiers to files without license Roland Hieber
2021-03-30 11:08 ` [OSS-Tools] [PATCH dt-utils 1/4] treewide: add SPDX identifiers to files with GPL-2.0-or-later license Roland Hieber
2021-03-30 11:22   ` Ahmad Fatoum
2021-03-30 13:30     ` Uwe Kleine-König
2021-03-30 13:50       ` Ahmad Fatoum
2021-03-30 14:00         ` Uwe Kleine-König
2021-03-30 14:04           ` Ahmad Fatoum
2021-03-30 15:53         ` Roland Hieber
2021-03-30 17:31           ` Ahmad Fatoum
2021-03-31 10:03             ` Roland Hieber [this message]
2021-03-31 10:10               ` Roland Hieber
2021-03-30 12:49 ` Uwe Kleine-König
2023-08-01 10:10 ` Roland Hieber
2023-08-01 10:12   ` Roland Hieber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210331100305.e4klllzxx4p7yhxo@pengutronix.de \
    --to=rhi@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=oss-tools@pengutronix.de \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox