From: Michael Olbrich <m.olbrich@pengutronix.de>
To: oss-tools@pengutronix.de
Cc: Michael Olbrich <m.olbrich@pengutronix.de>
Subject: [OSS-Tools] [PATCH v4 1/3] libdt: only requires a partname for mtd
Date: Wed, 11 May 2022 10:21:23 +0200 [thread overview]
Message-ID: <20220511082125.4187531-2-m.olbrich@pengutronix.de> (raw)
In-Reply-To: <20220511082125.4187531-1-m.olbrich@pengutronix.de>
It's not used anywhere else.
Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
---
No changes in v3 and v4.
src/libdt.c | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/src/libdt.c b/src/libdt.c
index 59e76d336d8d..48c31931e8a1 100644
--- a/src/libdt.c
+++ b/src/libdt.c
@@ -2381,7 +2381,6 @@ int of_get_devicepath(struct device_node *partition_node, char **devpath, off_t
{
struct device_node *node;
struct udev_device *dev, *partdev, *mtd;
- const char *partname;
int ret;
*offset = 0;
@@ -2451,16 +2450,18 @@ int of_get_devicepath(struct device_node *partition_node, char **devpath, off_t
return -ENODEV;
}
- /* find the name of the partition... */
- ret = of_property_read_string(partition_node, "label", &partname);
- if (ret) {
- fprintf(stderr, "%s: no 'label' property found in %s\n", __func__,
- partition_node->full_name);
- return ret;
- }
-
mtd = of_find_mtd_device(dev);
if (mtd) {
+ const char *partname;
+
+ /* find the name of the partition... */
+ ret = of_property_read_string(partition_node, "label", &partname);
+ if (ret) {
+ fprintf(stderr, "%s: no 'label' property found in %s\n", __func__,
+ partition_node->full_name);
+ return ret;
+ }
+
/* ...find the udev_device by partition name... */
partdev = device_find_mtd_partition(dev, partname);
if (!partdev)
--
2.30.2
next prev parent reply other threads:[~2022-05-11 8:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 8:21 [OSS-Tools] [PATCH v4 0/3] improve barebox-state support on EFI system Michael Olbrich
2022-05-11 8:21 ` Michael Olbrich [this message]
2022-05-11 8:21 ` [OSS-Tools] [PATCH v4 2/3] libdt: add support for barebox, storage-by-uuid Michael Olbrich
2022-05-15 20:40 ` Roland Hieber
2022-05-16 7:56 ` Michael Olbrich
2023-05-31 15:13 ` [OSS-Tools] [PATCH fixup 1/2] libdt: remove ultimately unused variables Ahmad Fatoum
2023-05-31 15:13 ` [OSS-Tools] [PATCH fixup 2/2] libdt: fix possible use of uninitialized variable Ahmad Fatoum
2023-06-05 9:15 ` [OSS-Tools] [PATCH fixup 1/2] libdt: remove ultimately unused variables Roland Hieber
2023-06-05 9:30 ` Ahmad Fatoum
2023-06-05 12:31 ` Ahmad Fatoum
2023-06-05 12:33 ` Roland Hieber
2023-05-31 15:14 ` [OSS-Tools] [PATCH v4 2/3] libdt: add support for barebox, storage-by-uuid Ahmad Fatoum
2022-05-11 8:21 ` [OSS-Tools] [PATCH v4 3/3] state: automatically find state.dtb in the ESP Michael Olbrich
2022-05-15 21:04 ` [OSS-Tools] [PATCH v4 0/3] improve barebox-state support on EFI system Roland Hieber
2022-05-16 7:58 ` Michael Olbrich
2023-06-05 12:33 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220511082125.4187531-2-m.olbrich@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=oss-tools@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox