Re: [OSS-Tools] [PATCH v4 0/3] improve barebox-state support on EFI system

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Sun, May 15, 2022 at 11:04:39PM +0200, Roland Hieber wrote:
> On Wed, May 11, 2022 at 10:21:22AM +0200, Michael Olbrich wrote:
> > Hi,
> > 
> > so the discussion on the barebox ML resulted in a different binding for
> > this. Sascha has sent patches for that[1]. This is now mainline in Barebox.
> > 
> > So while this is 'v4' for this topic, all the patches except the last one
> > are actually different, so please drop the old series that is still present
> > in the next branch.
> 
> I noticed that you dropped the deep probe patch from your v2 to v4 too,
> but I think I will keep it to reduce the diff between barebox' and
> dt-utils' state.c, even if it's a noop on the userland side.

I added that patch to ensure that my patch applied to both files. But I
think there where other changes as well in code that I didn't touch. So if
you want to minimize the diff then you should probably pick some more
commits.

Michael

> > v2 had some Bugs that have been fixed in v3.
> > Added some improvements as suggested by Ahmad in v4.
> > 
> > In the device-tree it now looks like this:
> > 
> > ----------------------------------------------------------------------
> > / {
> > [...]
> >         state: state {
> > [...]
> >                 backend = <&barebox_state>;
> > [...]
> >         };
> > 
> >         disk {
> >                 compatible = "barebox,storage-by-uuid";
> >                 uuid = "deadbeaf";
> > 
> >                 partitions {
> >                         compatible = "fixed-partitions";
> >                         #address-cells = <2>;
> >                         #size-cells = <2>;
> > 
> >                         barebox_state: state@300000 {
> >                                 label = "barebox-state";
> >                                 reg = <0x0 0x300000 0x0 0x100000>;
> >                         };
> >                 };
> >         };
> > };
> > ----------------------------------------------------------------------
> > 
> > Regards,
> > Michael
> > 
> > [1] https://lore.barebox.org/barebox/20220207094953.949868-1-s.hauer@pengutronix.de/T/#t
> > 
> > Michael Olbrich (3):
> >   libdt: only requires a partname for mtd
> >   libdt: add support for barebox,storage-by-uuid
> >   state: automatically find state.dtb in the ESP
> > 
> >  src/barebox-state.c | 25 +++++++++++++
> >  src/libdt.c         | 91 ++++++++++++++++++++++++++++++++++++++-------
> >  2 files changed, 103 insertions(+), 13 deletions(-)
> > 
> > -- 
> > 2.30.2
> > 
> > 
> > 
> 
> -- 
> Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
> Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
> 31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |