From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 16 May 2022 09:58:13 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nqVcL-00FKne-Ps for lore@lore.pengutronix.de; Mon, 16 May 2022 09:58:13 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1nqVcK-0007Lw-C3; Mon, 16 May 2022 09:58:12 +0200 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nqVcJ-0007Le-1h; Mon, 16 May 2022 09:58:11 +0200 Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nqVcI-0000PM-Ph; Mon, 16 May 2022 09:58:10 +0200 Date: Mon, 16 May 2022 09:58:10 +0200 From: Michael Olbrich To: Roland Hieber Message-ID: <20220516075810.GD17580@pengutronix.de> Mail-Followup-To: Roland Hieber , oss-tools@pengutronix.de References: <20220511082125.4187531-1-m.olbrich@pengutronix.de> <20220515210439.srcyeggiqfscde7m@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220515210439.srcyeggiqfscde7m@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 09:56:40 up 46 days, 20:26, 76 users, load average: 0.12, 0.35, 0.32 User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [OSS-Tools] [PATCH v4 0/3] improve barebox-state support on EFI system X-BeenThere: oss-tools@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: Pengutronix Public Open-Source-Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: oss-tools@pengutronix.de Sender: "OSS-Tools" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: oss-tools-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Sun, May 15, 2022 at 11:04:39PM +0200, Roland Hieber wrote: > On Wed, May 11, 2022 at 10:21:22AM +0200, Michael Olbrich wrote: > > Hi, > > > > so the discussion on the barebox ML resulted in a different binding for > > this. Sascha has sent patches for that[1]. This is now mainline in Barebox. > > > > So while this is 'v4' for this topic, all the patches except the last one > > are actually different, so please drop the old series that is still present > > in the next branch. > > I noticed that you dropped the deep probe patch from your v2 to v4 too, > but I think I will keep it to reduce the diff between barebox' and > dt-utils' state.c, even if it's a noop on the userland side. I added that patch to ensure that my patch applied to both files. But I think there where other changes as well in code that I didn't touch. So if you want to minimize the diff then you should probably pick some more commits. Michael > > v2 had some Bugs that have been fixed in v3. > > Added some improvements as suggested by Ahmad in v4. > > > > In the device-tree it now looks like this: > > > > ---------------------------------------------------------------------- > > / { > > [...] > > state: state { > > [...] > > backend = <&barebox_state>; > > [...] > > }; > > > > disk { > > compatible = "barebox,storage-by-uuid"; > > uuid = "deadbeaf"; > > > > partitions { > > compatible = "fixed-partitions"; > > #address-cells = <2>; > > #size-cells = <2>; > > > > barebox_state: state@300000 { > > label = "barebox-state"; > > reg = <0x0 0x300000 0x0 0x100000>; > > }; > > }; > > }; > > }; > > ---------------------------------------------------------------------- > > > > Regards, > > Michael > > > > [1] https://lore.barebox.org/barebox/20220207094953.949868-1-s.hauer@pengutronix.de/T/#t > > > > Michael Olbrich (3): > > libdt: only requires a partname for mtd > > libdt: add support for barebox,storage-by-uuid > > state: automatically find state.dtb in the ESP > > > > src/barebox-state.c | 25 +++++++++++++ > > src/libdt.c | 91 ++++++++++++++++++++++++++++++++++++++------- > > 2 files changed, 103 insertions(+), 13 deletions(-) > > > > -- > > 2.30.2 > > > > > > > > -- > Roland Hieber, Pengutronix e.K. | r.hieber@pengutronix.de | > Steuerwalder Str. 21 | https://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |