From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 05 Jan 2023 17:05:35 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pDSkK-002e5j-51 for lore@lore.pengutronix.de; Thu, 05 Jan 2023 17:05:35 +0100 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1pDSkH-00041h-Sr; Thu, 05 Jan 2023 17:05:33 +0100 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pDSkF-00041I-O4; Thu, 05 Jan 2023 17:05:31 +0100 Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pDSkF-0041Ve-46; Thu, 05 Jan 2023 17:05:31 +0100 Received: from mtr by dude05.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pDSkE-00FxGN-Hs; Thu, 05 Jan 2023 17:05:30 +0100 From: Michael Tretter To: oss-tools@pengutronix.de Date: Thu, 5 Jan 2023 17:05:30 +0100 Message-Id: <20230105160530.3802682-1-m.tretter@pengutronix.de> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [OSS-Tools] [PATCH] plugin: remove sync variable X-BeenThere: oss-tools@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: Pengutronix Public Open-Source-Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mtr@pengutronix.de Sender: "OSS-Tools" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: oss-tools-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false The sync variable allows to disable sync on the GStreamer sink element. Currently it is set to true and never changed. With glibc 2.36, the variable conflicts with the definition of the `void sync()` symbol defined in /usr/include/unistd.h, which is a POSIX standard function. Having this variable is doubtful by itself, but conflicting with a POSIX declaration is bad. Signed-off-by: Michael Tretter --- plugin/gstplayer.cpp | 5 ----- 1 file changed, 5 deletions(-) diff --git a/plugin/gstplayer.cpp b/plugin/gstplayer.cpp index c0b12df08d40..ebb14ed2f7c4 100644 --- a/plugin/gstplayer.cpp +++ b/plugin/gstplayer.cpp @@ -10,8 +10,6 @@ Q_LOGGING_CATEGORY(lcGstPlayer, "gst.player", QtWarningMsg) -static bool sync = true; - QtGstPlayer::QtGstPlayer() : m_pipeline(NULL), m_sink(NULL), @@ -449,9 +447,6 @@ void QtGstPlayer::updatePipeline() g_signal_connect(m_pipeline, "deep-notify", G_CALLBACK(gst_object_default_deep_notify), NULL); - if (!sync) - g_object_set(G_OBJECT(sinkBin), "sync", FALSE, NULL); - setState(m_state); } -- 2.30.2