From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 13 Feb 2023 16:04:20 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pRaNR-006KG7-PJ for lore@lore.pengutronix.de; Mon, 13 Feb 2023 16:04:20 +0100 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1pRaNO-0000Bs-LU; Mon, 13 Feb 2023 16:04:18 +0100 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pRaNN-0000BN-PK; Mon, 13 Feb 2023 16:04:17 +0100 Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1pRaNN-0002BP-I0; Mon, 13 Feb 2023 16:04:17 +0100 Date: Mon, 13 Feb 2023 16:04:17 +0100 From: Michael Olbrich To: Marco Felsch Message-ID: <20230213150417.GI30852@pengutronix.de> Mail-Followup-To: Marco Felsch , oss-tools@pengutronix.de, graphics@pengutronix.de References: <20230213145723.4065393-1-m.felsch@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230213145723.4065393-1-m.felsch@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [OSS-Tools] [PATCH 1/3] gstplayer: make use of playbin3 X-BeenThere: oss-tools@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: Pengutronix Public Open-Source-Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: oss-tools@pengutronix.de, graphics@pengutronix.de Sender: "OSS-Tools" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: oss-tools-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false All 3 patches look good. Please push. mol On Mon, Feb 13, 2023 at 03:57:21PM +0100, Marco Felsch wrote: > Replace the 'playbin' by the more recent 'playbin3' element. > > Signed-off-by: Marco Felsch > --- > plugin/gstplayer.cpp | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/plugin/gstplayer.cpp b/plugin/gstplayer.cpp > index c0b12df..909843b 100644 > --- a/plugin/gstplayer.cpp > +++ b/plugin/gstplayer.cpp > @@ -408,14 +408,14 @@ void QtGstPlayer::updatePipeline() > QString prefix = "gst-pipeline:"; > QString source = m_source; > > - /* default pipeline (playbin) */ > + /* default pipeline (playbin3) */ > if (source.indexOf(prefix) != 0) { > - m_pipeline = gst_element_factory_make("playbin", NULL); > + m_pipeline = gst_element_factory_make("playbin3", NULL); > > g_signal_connect(m_pipeline, "element-setup", G_CALLBACK(setup_element_callback), this); > > if (!m_pipeline) { > - qCWarning(lcGstPlayer, "Failed to create playbin element, \ > + qCWarning(lcGstPlayer, "Failed to create playbin3 element, \ > is the GStreamer playback plugin installed?"); > return; > } > -- > 2.30.2 > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |