From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: oss-tools@pengutronix.de
Subject: [OSS-Tools] [PATCH 5/5] barebox-state: fix use after free in error path
Date: Wed, 31 May 2023 17:10:15 +0200 [thread overview]
Message-ID: <20230531151015.1404262-5-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20230531151015.1404262-1-a.fatoum@pengutronix.de>
blob_bin is freed a few lines above unconditionally, so freeing it
again in the error path will cause a double free.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
src/keystore-blob.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/keystore-blob.c b/src/keystore-blob.c
index ed6ecb4eaa25..8ec07f0a3d56 100644
--- a/src/keystore-blob.c
+++ b/src/keystore-blob.c
@@ -81,10 +81,8 @@ int keystore_get_secret(const char *name, const unsigned char **key, int *key_le
/* payload */
fd = open(blob_gen_payload, O_RDONLY);
- if (fd < 0) {
- free(blob_bin);
+ if (fd < 0)
return -errno;
- }
payload = xzalloc(len);
len = read(fd, payload, len);
--
2.39.2
next prev parent reply other threads:[~2023-05-31 15:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 15:10 [OSS-Tools] [PATCH 1/5] configure: pass -fno-strict-aliasing to GCC Ahmad Fatoum
2023-05-31 15:10 ` [OSS-Tools] [PATCH 2/5] libdt: fix issues of external function without prototype Ahmad Fatoum
2023-05-31 15:10 ` [OSS-Tools] [PATCH 3/5] libdt: use memcpy instead of strncpy Ahmad Fatoum
2023-05-31 15:10 ` [OSS-Tools] [PATCH 4/5] libdt: don't use old-style function definition Ahmad Fatoum
2023-05-31 15:10 ` Ahmad Fatoum [this message]
2023-06-02 12:45 ` [OSS-Tools] [PATCH 5/5] barebox-state: fix use after free in error path Roland Hieber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230531151015.1404262-5-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=oss-tools@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox