From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: oss-tools@pengutronix.de
Subject: [OSS-Tools] [PATCH fixup 2/2] libdt: fix possible use of uninitialized variable
Date: Wed, 31 May 2023 17:13:33 +0200 [thread overview]
Message-ID: <20230531151333.1407290-2-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20230531151333.1407290-1-a.fatoum@pengutronix.de>
property may not be always defined. So let's skip trying to do something
with it in that case.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
src/libdt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/libdt.c b/src/libdt.c
index 302ca7a76375..ca0502ac9483 100644
--- a/src/libdt.c
+++ b/src/libdt.c
@@ -2397,6 +2397,8 @@ static struct udev_device *of_find_device_by_uuid(struct udev_device *parent,
property = "ID_PART_TABLE_UUID";
else if (!strcmp(devtype, "partition"))
property = "ID_PART_ENTRY_UUID";
+ else
+ continue;
dev_uuid = udev_device_get_property_value(device, property);
if (dev_uuid && !strcasecmp(dev_uuid, uuid))
--
2.39.2
next prev parent reply other threads:[~2023-05-31 15:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 8:21 [OSS-Tools] [PATCH v4 0/3] improve barebox-state support on EFI system Michael Olbrich
2022-05-11 8:21 ` [OSS-Tools] [PATCH v4 1/3] libdt: only requires a partname for mtd Michael Olbrich
2022-05-11 8:21 ` [OSS-Tools] [PATCH v4 2/3] libdt: add support for barebox, storage-by-uuid Michael Olbrich
2022-05-15 20:40 ` Roland Hieber
2022-05-16 7:56 ` Michael Olbrich
2023-05-31 15:13 ` [OSS-Tools] [PATCH fixup 1/2] libdt: remove ultimately unused variables Ahmad Fatoum
2023-05-31 15:13 ` Ahmad Fatoum [this message]
2023-06-05 9:15 ` Roland Hieber
2023-06-05 9:30 ` Ahmad Fatoum
2023-06-05 12:31 ` Ahmad Fatoum
2023-06-05 12:33 ` Roland Hieber
2023-05-31 15:14 ` [OSS-Tools] [PATCH v4 2/3] libdt: add support for barebox, storage-by-uuid Ahmad Fatoum
2022-05-11 8:21 ` [OSS-Tools] [PATCH v4 3/3] state: automatically find state.dtb in the ESP Michael Olbrich
2022-05-15 21:04 ` [OSS-Tools] [PATCH v4 0/3] improve barebox-state support on EFI system Roland Hieber
2022-05-16 7:58 ` Michael Olbrich
2023-06-05 12:33 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230531151333.1407290-2-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=oss-tools@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox