From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 07 Jun 2023 11:02:52 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q6p49-00E7cQ-Na for lore@lore.pengutronix.de; Wed, 07 Jun 2023 11:02:52 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1q6p46-00013R-7v; Wed, 07 Jun 2023 11:02:50 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q6p45-000132-NA; Wed, 07 Jun 2023 11:02:49 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1q6p44-005hXc-04; Wed, 07 Jun 2023 11:02:48 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1q6p43-00BxbC-6q; Wed, 07 Jun 2023 11:02:47 +0200 Date: Wed, 7 Jun 2023 11:02:47 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Ahmad Fatoum Message-ID: <20230607090247.kfckx6wawwxz7lob@pengutronix.de> References: <20230531152253.1407395-1-a.fatoum@pengutronix.de> <20230531152253.1407395-4-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="by7fb5ypnci6gsc5" Content-Disposition: inline In-Reply-To: <20230531152253.1407395-4-a.fatoum@pengutronix.de> Subject: Re: [OSS-Tools] [PATCH 3/8] libdt: drop broken if-branch X-BeenThere: oss-tools@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: Pengutronix Public Open-Source-Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: oss-tools@pengutronix.de Sender: "OSS-Tools" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: oss-tools-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false --by7fb5ypnci6gsc5 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 31, 2023 at 05:22:48PM +0200, Ahmad Fatoum wrote: > device_find_block_device returns 0 on success, so the way the else if > clause is now, only if there is a block device, the code falls through. > If there is none, a 0 is returned, but devpath is not populated breaking > the contract of the function. Just drop the branch for now and add back > it later in a way that works. s/add back it/add it back/ Otherwise: Reviewed-by: Uwe Kleine-K=F6nig Thanks Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --by7fb5ypnci6gsc5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmSAR7YACgkQj4D7WH0S /k5gcQf/QrxfVrd5f5dY56hhOq6i/CBihkHrjkZ22s/xVJXxYmSkuKk4R7ELWc4/ A/HsjMkkAoNBpHFI4y+5Z4UxvhbQK6JocQwEynfdQDffk7k2HRrcmRXHBaIg4bbp 9swDmO4tO87KHkId4OHx00H1J55r4QIy+Al5nrkxJTdmj+sm2k8ir0dWEFa/oE50 C48AA1QHMIImZMAjQ0GHAf2fEoSx5oJ7bsTyISFlYnGykQvf5Yefa88d5JwAuURB 3mPoRfqELWcptuqbwaW9MP2KPqYs288AEto8bH7MZCN8xpvyltqtRMzq9pL0e58z Iqff+zmLInUA6lxd4nSyMPmDgrCyKw== =4pCv -----END PGP SIGNATURE----- --by7fb5ypnci6gsc5--