Re: [OSS-Tools] [PATCH v2 0/8] state: allow lookup of barebox state partition by Type GUID

[Roland Hieber <rhi@pengutronix.de>]

On Wed, Jun 07, 2023 at 02:16:20PM +0200, Ahmad Fatoum wrote:
> This implements the binding extension introduced to barebox here:
> https://lore.barebox.org/barebox/20230607120714.3083182-1-a.fatoum@pengutronix.de/T/#t
> 
> With this, barebox,state backend can optionally point at a device
> instead of a partition. If this device is GPT-partitioned and has
> a partition with a specific partition type GUID of
> 
>   4778ed65-bf42-45fa-9c5b-287a1dc4aab1
> 
> It will be taken.
> 
> This series also fixes an annoying issue of barebox-state triggering
> udev on every access, because the root block device corresponding
> to the device tree node was opened r/w.
> 
> barebox-state will now open the disk read-only if possible and if
> a partition exists that fits the barebox state location, it will
> be opened instead.
> 
> v1 -> v2:
>   - added Uwe's Reviewed-by
>   - fix typo spotted by Roland
>   - Rebase on top of next
>   - Sync with v2 of barebox series:
>     - fix typo (Sascha)
>     - define new cdev_find_child_by_gpt_typeuuid helper (Marco)
>   - handle case of iterating over partitions before disk in
>     cdev_from_block_device

Looks good to me now.

Reviewed-by: Roland Hieber <rhi@pengutronix.de>

> 
> Ahmad Fatoum (8):
>   state: backend: direct: open block device in read-only mode if
>     possible
>   libdt: factor out u64 sysattr parsing into helper
>   libdt: drop broken if-branch
>   libdt: factor out __of_cdev_find helper
>   libdt: use block device partition instead of parent if found
>   state: align with barebox use of of_cdev_find
>   libdt: use of_find_device_by_uuid for partuuid lookup
>   state: allow lookup of barebox state partition by Type GUID
> 
>  src/barebox-state/backend_bucket_direct.c |   5 +-
>  src/barebox-state/backend_storage.c       |   2 +-
>  src/barebox-state/state.c                 |  52 +++-
>  src/barebox-state/state.h                 |   3 +-
>  src/dt/common.h                           |   8 +
>  src/dt/dt.h                               |   7 +
>  src/libdt-utils.sym                       |   4 +
>  src/libdt.c                               | 336 ++++++++++++++++++----
>  src/linux/uuid.h                          |  24 ++
>  src/state.h                               |   4 +
>  10 files changed, 368 insertions(+), 77 deletions(-)
>  create mode 100644 src/linux/uuid.h
> 
> -- 
> 2.39.2
> 
> 
> 

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |