Re: [OSS-Tools] [PATCH 1/3] meson: options: use defaults of type boolean for boolean options

[Roland Hieber <rhi@pengutronix.de>]

On Mon, Jun 12, 2023 at 02:07:52PM +0200, Ahmad Fatoum wrote:
> From: Ahmad Fatoum <ahmad@a3f.at>
> 
> Building with newer meson versions alerts us that specifying defaults
> with a string type for non-string types is deprecated. This type
> confusion was not intentional, so fix that.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---

Reviewed-by: Roland Hieber <rhi@pengutronix.de>

>  meson_options.txt | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/meson_options.txt b/meson_options.txt
> index f80643aa6c73..04d9854a4b1b 100644
> --- a/meson_options.txt
> +++ b/meson_options.txt
> @@ -2,24 +2,24 @@
>  option(
>    'state-backward-compatibility',
>    type : 'boolean',
> -  value : 'false',
> +  value : false,
>    description : 'barebox-state: when using the "direct" storage backend, keep the on-disk format readable by barebox <= v2016.08.0')
>  
>  option(
>    'lock-device',
>    type : 'boolean',
> -  value : 'false',
> +  value : false,
>    description : 'lock device node instead of creating lockfile in /run')
>  
>  # build options
>  option(
>    'barebox-state',
>    type : 'boolean',
> -  value : 'true',
> +  value : true,
>    description : 'Build barebox-state utility')
>  
>  option(
>    'tests',
>    type : 'boolean',
> -  value : 'true',
> +  value : true,
>    description : 'Enable/Disable test suite')
> -- 
> 2.39.2
> 
> 
> 

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |