Re: [OSS-Tools] [PATCH dt-utils] meson: align libdt-utils version with autotools'

["Enrico Jörns" <ejo@pengutronix.de>]

Am Montag, dem 06.11.2023 um 13:04 +0100 schrieb Roland Hieber:
> On Mon, Nov 06, 2023 at 12:58:22PM +0100, Ahmad Fatoum wrote:
> > Makefile.am has:
> > 
> >   LIBDT_CURRENT=6
> >   LIBDT_REVISION=0
> >   LIBDT_AGE=0
> > 
> > along with a comment on how the values were chosen. Copy the comment and
> > the values into the meson.build as well, so appropriate symlinks
> > pointing at the versioned library are created. We forego the extra
> > complexity of having a common file that's read from both build systems
> > as we are intent on phasing out autotools anyway, once wrinkles such as
> > what's fixed here are ironed out.
> > 
> > Reported-by: Enrico Jörns <e.joerns@pengutronix.de>
> > Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> 
> Reviewed-by: Roland Hieber <rhi@pengutronix.de>
> 
> > ---
> >  meson.build | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/meson.build b/meson.build
> > index 9579e712dfea..9894d7311bb3 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -133,6 +133,15 @@ libdt = shared_library('dt-utils',
> >    c_args : ['-include', meson.current_build_dir() / 'version.h'],
> >    dependencies : [udevdep, versiondep],
> >    gnu_symbol_visibility : 'default',
> > +# If the library source code has changed at all since the last release,
> > +#   then increment revision (‘c:r:a’ becomes ‘c:r+1:a’).
> > +# If any interfaces have been added/removed/changed since the last release,
> > +#   then increment current, and set revision to 0.

Does this make sense?
Isn't "current" meant to mark *incompatible* public API changes?
This might be valid for "removed" or "changed", but not for "added".

How does "interfaces" differ from "public interfaces" below?

Regards, Enrico

> > +# If any public interfaces have been added since the last public release,
> > +#   then increment age.
> > +# If any interfaces have been removed or changed since the last release,
> > +#   then set age to 0.
> > +  version: '6.0.0',
> >    install : true)
> >  
> >  executable('barebox-state',
> > -- 
> > 2.39.2
> > 
> > 
> > 
> 

-- 
Pengutronix e.K.                           | Enrico Jörns                |
Embedded Linux Consulting & Support        | https://www.pengutronix.de/ |
Steuerwalder Str. 21                       | Phone: +49-5121-206917-180  |
31137 Hildesheim, Germany                  | Fax:   +49-5121-206917-9    |