From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 06 Nov 2023 13:12:52 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qzyTL-0009pJ-1l for lore@lore.pengutronix.de; Mon, 06 Nov 2023 13:12:52 +0100 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1qzyTK-00055o-LB; Mon, 06 Nov 2023 13:12:50 +0100 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[IPv6:::1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1qzyTJ-00055N-6E; Mon, 06 Nov 2023 13:12:49 +0100 Message-ID: <3f9dc13e7710d87ad6a022d07c0c3e2314c0e5a1.camel@pengutronix.de> From: Enrico =?ISO-8859-1?Q?J=F6rns?= To: Roland Hieber , Ahmad Fatoum Date: Mon, 06 Nov 2023 13:12:48 +0100 In-Reply-To: <20231106120426.qa7s6j7bktnxsp77@pengutronix.de> References: <20231106115822.268672-1-a.fatoum@pengutronix.de> <20231106120426.qa7s6j7bktnxsp77@pengutronix.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 Subject: Re: [OSS-Tools] [PATCH dt-utils] meson: align libdt-utils version with autotools' X-BeenThere: oss-tools@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: Pengutronix Public Open-Source-Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: oss-tools@pengutronix.de, Enrico =?ISO-8859-1?Q?J=F6rns?= Sender: "OSS-Tools" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: oss-tools-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Am Montag, dem 06.11.2023 um 13:04 +0100 schrieb Roland Hieber: > On Mon, Nov 06, 2023 at 12:58:22PM +0100, Ahmad Fatoum wrote: > > Makefile.am has: > >=20 > > =C2=A0 LIBDT_CURRENT=3D6 > > =C2=A0 LIBDT_REVISION=3D0 > > =C2=A0 LIBDT_AGE=3D0 > >=20 > > along with a comment on how the values were chosen. Copy the comment an= d > > the values into the meson.build as well, so appropriate symlinks > > pointing at the versioned library are created. We forego the extra > > complexity of having a common file that's read from both build systems > > as we are intent on phasing out autotools anyway, once wrinkles such as > > what's fixed here are ironed out. > >=20 > > Reported-by: Enrico J=C3=B6rns > > Signed-off-by: Ahmad Fatoum >=20 > Reviewed-by: Roland Hieber >=20 > > --- > > =C2=A0meson.build | 9 +++++++++ > > =C2=A01 file changed, 9 insertions(+) > >=20 > > diff --git a/meson.build b/meson.build > > index 9579e712dfea..9894d7311bb3 100644 > > --- a/meson.build > > +++ b/meson.build > > @@ -133,6 +133,15 @@ libdt =3D shared_library('dt-utils', > > =C2=A0=C2=A0 c_args : ['-include', meson.current_build_dir() / 'version= .h'], > > =C2=A0=C2=A0 dependencies : [udevdep, versiondep], > > =C2=A0=C2=A0 gnu_symbol_visibility : 'default', > > +# If the library source code has changed at all since the last release= , > > +#=C2=A0=C2=A0 then increment revision (=E2=80=98c:r:a=E2=80=99 becomes= =E2=80=98c:r+1:a=E2=80=99). > > +# If any interfaces have been added/removed/changed since the last rel= ease, > > +#=C2=A0=C2=A0 then increment current, and set revision to 0. Does this make sense? Isn't "current" meant to mark *incompatible* public API changes? This might be valid for "removed" or "changed", but not for "added". How does "interfaces" differ from "public interfaces" below? Regards, Enrico > > +# If any public interfaces have been added since the last public relea= se, > > +#=C2=A0=C2=A0 then increment age. > > +# If any interfaces have been removed or changed since the last releas= e, > > +#=C2=A0=C2=A0 then set age to 0. > > +=C2=A0 version: '6.0.0', > > =C2=A0=C2=A0 install : true) > > =C2=A0 > > =C2=A0executable('barebox-state', > > --=20 > > 2.39.2 > >=20 > >=20 > >=20 >=20 --=20 Pengutronix e.K.=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| Enrico J=C3=B6rns=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| Embedded Linux Consulting & Support=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0| https://www.pengutronix.de/ | Steuerwalder Str. 21=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0| Phone: +49-5121-206917-180=C2=A0=C2=A0| 31137 Hildesheim, Germany=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| Fax:=C2=A0=C2= =A0=C2=A0+49-5121-206917-9=C2=A0=C2=A0=C2=A0=C2=A0|