From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: References: From: Ahmad Fatoum Message-ID: <4904b4eb-2ae9-5b73-a7bb-d996522efb08@pengutronix.de> Date: Wed, 10 Feb 2021 10:41:13 +0100 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Subject: Re: [OSS-Tools] [PATCH dt-utils] state: use /run to store lockfile List-Id: Pengutronix Public Open-Source-Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: oss-tools-bounces@pengutronix.de Sender: "OSS-Tools" To: Stefan Agner , oss-tools@pengutronix.de On 29.11.20 22:11, Stefan Agner wrote: > The current location /var/lock is considered legacy (at least by > systemd). Just use /run to store the lockfile and append the usual .lock > suffix. > > Signed-off-by: Stefan Agner Tested-by: Ahmad Fatoum > --- > src/barebox-state.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/src/barebox-state.c b/src/barebox-state.c > index 946a8db..16a8c9f 100644 > --- a/src/barebox-state.c > +++ b/src/barebox-state.c > @@ -38,6 +38,8 @@ > #include
> #include > > +#define BAREBOX_STATE_LOCKFILE "/run/barebox-state.lock" > + > struct state_variable; > > static int __state_uint8_set(struct state_variable *var, const char > *val); > @@ -505,15 +507,15 @@ int main(int argc, char *argv[]) > ++nr_states; > } > > - lock_fd = open("/var/lock/barebox-state", O_CREAT | O_RDWR, 0600); > + lock_fd = open(BAREBOX_STATE_LOCKFILE, O_CREAT | O_RDWR, 0600); > if (lock_fd < 0) { > - pr_err("Failed to open lock-file /var/lock/barebox-state\n"); > + pr_err("Failed to open lock-file " BAREBOX_STATE_LOCKFILE "\n"); > exit(1); > } > > ret = flock(lock_fd, LOCK_EX); > if (ret < 0) { > - pr_err("Failed to lock /var/lock/barebox-state: %m\n"); > + pr_err("Failed to lock " BAREBOX_STATE_LOCKFILE ": %m\n"); > close(lock_fd); > exit(1); > } > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ OSS-Tools mailing list OSS-Tools@pengutronix.de