From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 06 Nov 2023 14:59:34 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1r008b-000Dm9-1R for lore@lore.pengutronix.de; Mon, 06 Nov 2023 14:59:34 +0100 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1r008a-00068P-LZ; Mon, 06 Nov 2023 14:59:32 +0100 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[IPv6:::1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1r008Z-00067y-6y; Mon, 06 Nov 2023 14:59:31 +0100 Message-ID: <69c6355ea799c46a4b7fc02cd32665efe69f167e.camel@pengutronix.de> From: Enrico =?ISO-8859-1?Q?J=F6rns?= To: Ahmad Fatoum , Roland Hieber Date: Mon, 06 Nov 2023 14:59:30 +0100 In-Reply-To: <16005265-1560-721a-b208-e98df874f3ba@pengutronix.de> References: <20231106115822.268672-1-a.fatoum@pengutronix.de> <20231106120426.qa7s6j7bktnxsp77@pengutronix.de> <3f9dc13e7710d87ad6a022d07c0c3e2314c0e5a1.camel@pengutronix.de> <16005265-1560-721a-b208-e98df874f3ba@pengutronix.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 Subject: Re: [OSS-Tools] [PATCH dt-utils] meson: align libdt-utils version with autotools' X-BeenThere: oss-tools@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: Pengutronix Public Open-Source-Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: oss-tools@pengutronix.de, Enrico =?ISO-8859-1?Q?J=F6rns?= Sender: "OSS-Tools" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: oss-tools-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Hi Ahmad, Am Montag, dem 06.11.2023 um 14:44 +0100 schrieb Ahmad Fatoum: > Hello Enrico, >=20 > On 06.11.23 13:12, Enrico J=C3=B6rns wrote: > > Am Montag, dem 06.11.2023 um 13:04 +0100 schrieb Roland Hieber: > > > On Mon, Nov 06, 2023 at 12:58:22PM +0100, Ahmad Fatoum wrote: > > > > Makefile.am has: > > > >=20 > > > > =C2=A0 LIBDT_CURRENT=3D6 > > > > =C2=A0 LIBDT_REVISION=3D0 > > > > =C2=A0 LIBDT_AGE=3D0 > > > >=20 > > > > along with a comment on how the values were chosen. Copy the commen= t and > > > > the values into the meson.build as well, so appropriate symlinks > > > > pointing at the versioned library are created. We forego the extra > > > > complexity of having a common file that's read from both build syst= ems > > > > as we are intent on phasing out autotools anyway, once wrinkles suc= h as > > > > what's fixed here are ironed out. > > > >=20 > > > > Reported-by: Enrico J=C3=B6rns > > > > Signed-off-by: Ahmad Fatoum > > >=20 > > > Reviewed-by: Roland Hieber > > >=20 > > > > --- > > > > =C2=A0meson.build | 9 +++++++++ > > > > =C2=A01 file changed, 9 insertions(+) > > > >=20 > > > > diff --git a/meson.build b/meson.build > > > > index 9579e712dfea..9894d7311bb3 100644 > > > > --- a/meson.build > > > > +++ b/meson.build > > > > @@ -133,6 +133,15 @@ libdt =3D shared_library('dt-utils', > > > > =C2=A0=C2=A0 c_args : ['-include', meson.current_build_dir() / 'ver= sion.h'], > > > > =C2=A0=C2=A0 dependencies : [udevdep, versiondep], > > > > =C2=A0=C2=A0 gnu_symbol_visibility : 'default', > > > > +# If the library source code has changed at all since the last rel= ease, > > > > +#=C2=A0=C2=A0 then increment revision (=E2=80=98c:r:a=E2=80=99 bec= omes =E2=80=98c:r+1:a=E2=80=99). > > > > +# If any interfaces have been added/removed/changed since the last= release, > > > > +#=C2=A0=C2=A0 then increment current, and set revision to 0. > >=20 > > Does this make sense? >=20 > It was copied into Makefile.am verbatim from the libtool documentation: > https://www.gnu.org/software/libtool/manual/html_node/Updating-version-in= fo.html thank you for the link, I guess this clarifies the versioning purpose for m= e a bit better. Haven't looked at this topic in that detail yet either. =F0=9F=98=89 Maybe it would make sense to just refer to generic libtool versioning schem= e (and probably include the link) instead of duplicating the text here? Anyway, I would be fine with both variants in the first round! Best regards Enrico > > Isn't "current" meant to mark *incompatible* public API changes? >=20 > libtool numbering is new to me as well, but apparently "Current" is the m= ost recent > interface number that this library implements. >=20 > The major version number should thus be current - age, not just current. > I will fix that in v2. See > https://www.gnu.org/software/libtool/manual/html_node/Libtool-versioning.= html > https://gitlab.gnome.org/GNOME/gcab/-/merge_requests/6/diffs?commit_id=3D= 2c8048f74ec8c088397d47730aa47c574526918f >=20 > > This might be valid for "removed" or "changed", but not for "added". > >=20 > > How does "interfaces" differ from "public interfaces" below? >=20 > No difference AFAIK. >=20 > Cheers, > Ahmad >=20 > >=20 > > Regards, Enrico > >=20 > > > > +# If any public interfaces have been added since the last public r= elease, > > > > +#=C2=A0=C2=A0 then increment age. > > > > +# If any interfaces have been removed or changed since the last re= lease, > > > > +#=C2=A0=C2=A0 then set age to 0. > > > > +=C2=A0 version: '6.0.0', > > > > =C2=A0=C2=A0 install : true) > > > > =C2=A0 > > > > =C2=A0executable('barebox-state', > > > > --=20 > > > > 2.39.2 > > > >=20 > > > >=20 > > > >=20 > > >=20 > >=20 >=20 --=20 Pengutronix e.K.=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| Enrico J=C3=B6rns=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| Embedded Linux Consulting & Support=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0| https://www.pengutronix.de/ | Steuerwalder Str. 21=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0| Phone: +49-5121-206917-180=C2=A0=C2=A0| 31137 Hildesheim, Germany=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| Fax:=C2=A0=C2= =A0=C2=A0+49-5121-206917-9=C2=A0=C2=A0=C2=A0=C2=A0|