From: "Ulrich Ölmann" <u.oelmann@pengutronix.de>
To: Pengutronix Public Open-Source-Development <oss-tools@pengutronix.de>
Cc: entwicklung@pengutronix.de
Subject: Re: [OSS-Tools] [PATCH dt-utils 11/12] state: fix formatting of "off_t" variables
Date: Wed, 06 Feb 2019 07:25:51 +0100 [thread overview]
Message-ID: <6rftt14emo.fsf@pengutronix.de> (raw)
In-Reply-To: <20190204090631.dhrkz76qmbd5m6io@pengutronix.de>
On Mon, Feb 04 2019 at 10:06 +0100, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> On Mon, Feb 04, 2019 at 08:54:29AM +0100, Juergen Borleis wrote:
>> On Sunday 03 February 2019 22:48:06 Ulrich Ölmann wrote:
>> > Explicitely casting an "off_t" variable to "long long" and formatting it
>> > via "%lld" or "%llx" respectively makes 32- as well as 64-bit compilers
>> > happy (tested with gcc-8.2.1 and clang-7.0.1).
>>
>> Könnte hier der Cast (intmax_t) und der Prefix 'j' vielleicht besser sein?
>>
>> off_t blub;
>>
>> printf("Blub is: %jd\n", (intmax_t)blub);
>
> Note: the j length modifier exists only since glibc 2.1. Don't know
> about non-Linux (or alternative Linux) libc implementations. (Do we care
> about those?). Just checked the OpenSolaris state, printf there knows
> about 'j', but notes:
>
> If the j length modifier is used, 32-bit applications that
> were compiled using c89 on releases prior to Solaris 10 will
> experience undefined behavior
Unfortunately using "%j" is not an option as this code is shared with
barebox' state implementation and barebox only supports a subset of the
formats that glibc offers which does not include "%j", see [1].
Best regards
Ulrich
[1] https://github.com/saschahauer/barebox/blob/master/lib/vsprintf.c#L364
--
Pengutronix e.K. | Ulrich Ölmann |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
OSS-Tools mailing list
OSS-Tools@pengutronix.de
next prev parent reply other threads:[~2019-02-06 6:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-03 21:47 [OSS-Tools] [PATCH dt-utils 00/12] Diverse patches mainly removing bugs and warnings Ulrich Ölmann
2019-02-03 21:47 ` [OSS-Tools] [PATCH dt-utils 01/12] common: align declarations of dev_add_param_*() functions with barebox Ulrich Ölmann
2019-02-03 21:47 ` [OSS-Tools] [PATCH dt-utils 02/12] of_get_devicepath: again correct comment Ulrich Ölmann
2019-02-03 21:47 ` [OSS-Tools] [PATCH dt-utils 03/12] barebox-state: fix usage of multiple state instances Ulrich Ölmann
2019-02-03 21:47 ` [OSS-Tools] [PATCH dt-utils 04/12] barebox-state: complete cmdline options Ulrich Ölmann
2019-02-03 21:48 ` [OSS-Tools] [PATCH dt-utils 05/12] barebox-state: add cmdline option "--version" Ulrich Ölmann
2019-02-03 21:48 ` [OSS-Tools] [PATCH dt-utils 06/12] barebox-state: remove declaration of __state_uint8_get() Ulrich Ölmann
2019-02-03 21:48 ` [OSS-Tools] [PATCH dt-utils 07/12] barebox-state: remove unused variables Ulrich Ölmann
2019-02-03 21:48 ` [OSS-Tools] [PATCH dt-utils 08/12] keystore-blob: remove unused variable Ulrich Ölmann
2019-02-03 21:48 ` [OSS-Tools] [PATCH dt-utils 09/12] base64: " Ulrich Ölmann
2019-02-03 21:48 ` [OSS-Tools] [PATCH dt-utils 10/12] base64: remove duplicate ‘const’ declaration specifier Ulrich Ölmann
2019-02-03 21:48 ` [OSS-Tools] [PATCH dt-utils 11/12] state: fix formatting of "off_t" variables Ulrich Ölmann
2019-02-04 7:54 ` Juergen Borleis
2019-02-04 9:06 ` Uwe Kleine-König
2019-02-06 6:25 ` Ulrich Ölmann [this message]
2019-02-03 21:48 ` [OSS-Tools] [PATCH dt-utils 12/12] state: fix formatting of "uint32_t" variables Ulrich Ölmann
2019-02-07 11:43 ` [OSS-Tools] [PATCH dt-utils 00/12] Diverse patches mainly removing bugs and warnings Roland Hieber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6rftt14emo.fsf@pengutronix.de \
--to=u.oelmann@pengutronix.de \
--cc=entwicklung@pengutronix.de \
--cc=oss-tools@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox