Re: [OSS-Tools] [PATCH dt-utils] dtblint: add support for fsl, imx8mp-iomuxc

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hello Uwe,

thanks for your patch.

On 02.04.24 15:09, Uwe Kleine-König wrote:
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Please add the version of the reference manual you took these values from.

> ---
>  src/dtblint-imx-pinmux.c | 1317 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 1317 insertions(+)
> 

> +		.padname = "SD1_DATA5",
> +		.swmux_regoffset = 0x0a8,
> +		.swmux_reset_default = 0x00000005,
> +		.swmux_writeable_mask = 0x00000017,
> +		.swpad_regoffset = 0x308,
> +		.swpad_reset_default = 0x00000106,
> +		.swpad_writeable_mask = 0x000001f6,
> +		.swpad_writeable_mask = 0x000001f6,

This line is duplicated.

> +		.padname = "ECSPI2_SS0",
> +		.swmux_regoffset = 0x1fc,
> +		.swmux_reset_default = 0x00000005,
> +		.swmux_writeable_mask = 0x00000017,
> +		.swpad_regoffset = 0x45c,
> +		.swpad_reset_default = 0x00000106,
> +		.swpad_writeable_mask = 0x000001f6,
> +		.swpad_writeable_mask = 0x000001f6,

This is also duplicated.

> +	/* regname="AUDIOMIX_PDM_MIC_PDM_BITSTREAM_SELECT_INPUT_0" regoffset=0x4c0 reset_default=0x00000000 */
> +	/* regname="AUDIOMIX_PDM_MIC_PDM_BITSTREAM_SELECT_INPUT_1" regoffset=0x4c4 reset_default=0x00000000 */
> +	/* regname="AUDIOMIX_PDM_MIC_PDM_BITSTREAM_SELECT_INPUT_2" regoffset=0x4c8 reset_default=0x00000000 */
> +	/* regname="AUDIOMIX_PDM_MIC_PDM_BITSTREAM_SELECT_INPUT_3" regoffset=0x4cc reset_default=0x00000000 */

[snip]

> +	/* regname="USDHC3_STROBE_SELECT_INPUT" regoffset=0x630 reset_default=0x00000000 */
> +	/* regname="USDHC3_WP_ON_SELECT_INPUT" regoffset=0x634 reset_default=0x00000000 */

What are these comments about?


Cheers,
Ahmad

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |