From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 14 Jun 2024 15:47:13 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sI7Gr-005xQJ-1a for lore@lore.pengutronix.de; Fri, 14 Jun 2024 15:47:13 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1sI7Gq-0002bM-7Z; Fri, 14 Jun 2024 15:47:12 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sI7Go-0002b4-Ng; Fri, 14 Jun 2024 15:47:10 +0200 Received: from [2a0a:edc0:0:900:1d::4e] (helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sI7Go-002HSR-8Y; Fri, 14 Jun 2024 15:47:10 +0200 Received: from pza by lupine with local (Exim 4.96) (envelope-from ) id 1sI7Go-0009AM-0e; Fri, 14 Jun 2024 15:47:10 +0200 Message-ID: From: Philipp Zabel To: LI Qingwu , oss-tools@pengutronix.de, m.felsch@pengutronix.de Date: Fri, 14 Jun 2024 15:47:10 +0200 In-Reply-To: <20240614092308.1429018-3-Qing-wu.Li@leica-geosystems.com.cn> References: <20240614092308.1429018-1-Qing-wu.Li@leica-geosystems.com.cn> <20240614092308.1429018-3-Qing-wu.Li@leica-geosystems.com.cn> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 Subject: Re: [OSS-Tools] [PATCH platsch V4 3/4] platsch: split into platsch and libplatsch X-BeenThere: oss-tools@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: Pengutronix Public Open-Source-Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "OSS-Tools" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: oss-tools-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On Fr, 2024-06-14 at 11:23 +0200, LI Qingwu wrote: > Signed-off-by: LI Qingwu > --- > libplatsch.c | 590 +++++++++++++++++++++++++++++++++++++++++++++++++++ > libplatsch.h | 51 +++++ > meson.build | 7 +- > platsch.c | 582 +------------------------------------------------- > 4 files changed, 652 insertions(+), 578 deletions(-) > create mode 100644 libplatsch.c > create mode 100644 libplatsch.h >=20 > diff --git a/libplatsch.c b/libplatsch.c > new file mode 100644 > index 0000000..1d48e0e > --- /dev/null > +++ b/libplatsch.c > @@ -0,0 +1,590 @@ [...] > +ssize_t readfull(int fd, void *buf, size_t count) [...] > +void draw_buffer(struct modeset_dev *dev, const char *dir, const char *b= ase) [...] > +void update_display(struct modeset_dev *dev) Should these be made static? [...] > diff --git a/meson.build b/meson.build > index 0aadbe9..4c2ad7b 100644 > --- a/meson.build > +++ b/meson.build > @@ -1,13 +1,10 @@ > project('platsch', 'c', version: '2024.06.0') > =20 > dep_libdrm =3D dependency('libdrm', version : '>=3D 2.4.112', required := true) > -sources =3D ['platsch.c'] > +sources =3D ['libplatsch.c'] IMHO this should be: platsch_sources =3D [ 'platsch.c' ] libplasch_sources =3D [ 'libplatsch.c', 'libplatsch.h' ] > -# Define the headers > -headers =3D ['platsch.h'] > =20 > -# Create the platsch executable Please don't add lines that are removed right away in the next patch. This belongs in Patch 2. > -executable('platsch', What about the platsch executable? It should not be removed. > +libplatsch =3D static_library('libplatsch', > sources, > dependencies: dep_libdrm, > install: true, > diff --git a/platsch.c b/platsch.c > index 1aaa8d5..917fec0 100644 regards Philipp