mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>,
	Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 7/8] cdev: Add function to get unallocated start of device
Date: Tue, 12 Oct 2021 09:52:51 +0200
Message-ID: <05f86cbe-ad12-f957-8e51-58e7d9b3b830@pengutronix.de> (raw)
In-Reply-To: <20211012073352.4071559-8-s.hauer@pengutronix.de>

On 12.10.21 09:33, Sascha Hauer wrote:
> On several SoCs barebox is written to the raw device in front of the
> first partition. So far we blindly trust that there is enough space
> available for the barebox image. Start changing this by adding a
> function that retrieves the available space.
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>  common/partitions.c | 28 ++++++++++++++++++++++++++++
>  include/driver.h    |  1 +
>  2 files changed, 29 insertions(+)
> 
> diff --git a/common/partitions.c b/common/partitions.c
> index d80878e065..e36341fc1e 100644
> --- a/common/partitions.c
> +++ b/common/partitions.c
> @@ -156,3 +156,31 @@ int partition_parser_register(struct partition_parser *p)
>  
>  	return 0;
>  }
> +
> +/**
> + * cdev_unallocated_start - return unallocated space
> + * @name: The cdev name
> + *
> + * This function returns the space that is not allocated by any partition
> + * at the start of a device.
> + *
> + * Return: The unallocated space at the start of the device in bytes
> + */
> +loff_t cdev_unallocated_start(const char *name)

That name is a bit misleading. It's either cdev_allocated_start
or cdev_unallocated_space. Also cdev_ for a function not taking a cdev
is unexpected. Perhaps define devpath_to_cdev(s) as
cdev_by_name(devpath_to_name(s)) and have the caller pass in the cdev?

> +{
> +	struct cdev *cdev, *partcdev;
> +	loff_t start;
> +
> +	cdev = cdev_by_name(name);
> +	if (!cdev)
> +		return 0;
> +
> +	start = cdev->size;
> +
> +	list_for_each_entry(partcdev, &cdev->partitions, partition_entry) {
> +		if (partcdev->offset < start)
> +			start = partcdev->offset;
> +	}
> +
> +	return start;
> +}
> diff --git a/include/driver.h b/include/driver.h
> index c7f5903fce..38aa3cf8f5 100644
> --- a/include/driver.h
> +++ b/include/driver.h
> @@ -494,6 +494,7 @@ ssize_t cdev_read(struct cdev *cdev, void *buf, size_t count, loff_t offset, ulo
>  ssize_t cdev_write(struct cdev *cdev, const void *buf, size_t count, loff_t offset, ulong flags);
>  int cdev_ioctl(struct cdev *cdev, int cmd, void *buf);
>  int cdev_erase(struct cdev *cdev, loff_t count, loff_t offset);
> +loff_t cdev_unallocated_start(const char *name);
>  
>  #define DEVFS_PARTITION_FIXED		(1U << 0)
>  #define DEVFS_PARTITION_READONLY	(1U << 1)
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


  reply	other threads:[~2021-10-12  7:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-12  7:33 [PATCH v2 0/8] RK3568 updates Sascha Hauer
2021-10-12  7:33 ` [PATCH 1/8] phy: rockchip: Add dummy driver for child node Sascha Hauer
2021-10-12  7:33 ` [PATCH 2/8] ARM: Rockchip rk3568 EVB: Enable deep probe Sascha Hauer
2021-10-12  7:33 ` [PATCH 3/8] ARM: Rockchip: rk3568 EVB: use 64bit partition sizes Sascha Hauer
2021-10-12  7:33 ` [PATCH 4/8] phy: rockchip-inno-usb2: handle disabled child nodes gracefully Sascha Hauer
2021-10-12  7:33 ` [PATCH 5/8] usb: dwc3: reset controller before using it Sascha Hauer
2021-10-12  7:33 ` [PATCH 6/8] ARM: rk3568: Detect USB boot Sascha Hauer
2021-10-12  7:33 ` [PATCH 7/8] cdev: Add function to get unallocated start of device Sascha Hauer
2021-10-12  7:52   ` Ahmad Fatoum [this message]
2021-10-12  8:31     ` Sascha Hauer
2021-10-12  7:33 ` [PATCH 8/8] ARM: Rockchip: RK3568: implement failsafe barebox update Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05f86cbe-ad12-f957-8e51-58e7d9b3b830@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

mail archive of the barebox mailing list

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lore.barebox.org/barebox/0 barebox/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 barebox barebox/ https://lore.barebox.org/barebox \
		barebox@lists.infradead.org
	public-inbox-index barebox

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git