mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Steffen Hemer <S.Hemer@phytec.de>,
	"barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: Compile with CONSOLE_NONE
Date: Mon, 20 Nov 2023 08:26:36 +0100	[thread overview]
Message-ID: <126c4f25-a6d7-11b2-8a2a-d1f349a94675@pengutronix.de> (raw)
In-Reply-To: <49b721a9-cd86-49c0-bc04-6cfae0e2ea20@phytec.de>

Hello Steffen,

On 16.11.23 17:01, Steffen Hemer wrote:
> Hey everyone,
> 
> did somebody recently compile with CONFIG_CONSOLE_NONE set??
> For an am335x build (so with omap_defconfig), I get a linker error for 
> both v2022.09.0 and recent:
> 
> arm-linux-gnueabihf-ld: common/bootm.o: in function `bootm_boot':
> barebox/common/bootm.c:584: undefined reference to `console_list'
> 
> I found that this config was rotten already once:
> 
> https://lore.barebox.org/barebox/CANvTkNYwuCuGQMY40VC=dJxzW8rhBjDA_HE_Mb8AuV9iep7sYw@mail.gmail.com/t/
> 
> May that be the case again?

Thanks for the report. I indeed broke CONFIG_CONSOLE_NONE a while back.
Please see the series I just sent out that should fix that.

To avoid future regressions, we should add a defconfig with CONFIG_CONSOLE_NONE,
so they get regular testing by Github CI.

Could you submit a patch with one such config? Optimally, it would have other
less used size-conscious options enabled as well to get more coverage.

Cheers,
Ahmad


> 
> Regards
> 
> Steffen
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |




      reply	other threads:[~2023-11-20  7:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-16 16:01 Steffen Hemer
2023-11-20  7:26 ` Ahmad Fatoum [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=126c4f25-a6d7-11b2-8a2a-d1f349a94675@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=S.Hemer@phytec.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox