From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@barebox.org>
Cc: "Claude Opus 4.6" <noreply@anthropic.com>
Subject: Re: [PATCH] x86: fix initjmp storing base pointer at wrong address
Date: Mon, 13 Apr 2026 16:35:48 +0200 [thread overview]
Message-ID: <177609094889.3571925.9430359342195933849.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20260323071738.4005127-1-a.fatoum@barebox.org>
On Mon, 23 Mar 2026 08:17:28 +0100, Ahmad Fatoum wrote:
> initjmp was writing zero to 8(%edx), which is func + 8 (corrupting
> memory at the function pointer address), instead of 8(%eax), which is
> the __ebp (base pointer) slot in the jmp_buf. When longjmp later
> restored the buffer, it would load uninitialized data into %ebp.
>
> With regparm(3), the arguments are passed as:
> %eax = jmp_buf, %edx = func, %ecx = stack_top
>
> [...]
Applied, thanks!
[1/1] x86: fix initjmp storing base pointer at wrong address
https://git.pengutronix.de/cgit/barebox/commit/?id=29f6d89ef50b (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2026-04-13 14:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 7:17 Ahmad Fatoum
2026-04-13 14:35 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177609094889.3571925.9430359342195933849.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@barebox.org \
--cc=barebox@lists.infradead.org \
--cc=noreply@anthropic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox