From: Sascha Hauer <s.hauer@pengutronix.de>
To: "open list:BAREBOX" <barebox@lists.infradead.org>,
Stephano Cetola <stephano@cetola.net>
Subject: Re: [PATCH v3] spi: rockchip: initialize bus_num to -1
Date: Tue, 25 Aug 2026 15:49:17 +0200 [thread overview]
Message-ID: <178766575747.677163.14367284476409610691.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20260824-send-spi-rockchip-busnum-v3-1-96ef89a157f7@cetola.net>
On Mon, 24 Aug 2026 18:21:05 -0700, Stephano Cetola wrote:
> spi_register_controller() only runs the OF alias lookup when
> ctrl->bus_num is negative. This driver's kzalloc'd ctlr leaves
> bus_num at 0. The lookup gets skipped. Every Rockchip SPI controller
> ends up on bus 0.
>
> Any board that enables two Rockchip SPI controllers at once hits this
> bug. Both end up on bus 0. Looking one up by bus number can then
> return the wrong controller.
>
> [...]
Applied, thanks!
[1/1] spi: rockchip: initialize bus_num to -1
https://git.pengutronix.de/cgit/barebox/commit/?id=df1055a2e0dd (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
next prev parent reply other threads:[~2026-08-25 13:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 1:21 Stephano Cetola
2026-08-25 13:49 ` Sascha Hauer [this message]
[not found] <202608272006258002394@armdesigner.com>
2026-08-27 12:55 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178766575747.677163.14367284476409610691.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=stephano@cetola.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox