From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: Re: [PATCH] efi: loader: accept NULL DevicePath in LoadImage when SourceBuffer is given
Date: Fri, 28 Aug 2026 14:14:32 +0200 [thread overview]
Message-ID: <178791927279.421663.3598324641369675379.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20260826114521.2919654-1-a.fatoum@pengutronix.de>
On Wed, 26 Aug 2026 13:45:01 +0200, Ahmad Fatoum wrote:
> The UEFI specification only requires DevicePath when no SourceBuffer is
> given. Loading an image from memory with a NULL DevicePath is valid and
> results in a loaded image without device handle and file path. That's what
> EDK2 does and what the U-Boot code this was imported from does as well, as
> it ignores the result of efi_dp_split_file_path().
>
> barebox on the other hand checks the result and as efi_dp_dup(NULL) returns
> NULL, LoadImage fails with the misleading EFI_OUT_OF_RESOURCES. This breaks
> chainloading from a barebox EFI payload running on top of the barebox EFI
> loader: the payload passes the device path of its own device handle, which
> it doesn't have when it was booted via QEMU's fw_cfg, so it passes NULL.
>
> [...]
Applied, thanks!
[1/1] efi: loader: accept NULL DevicePath in LoadImage when SourceBuffer is given
https://git.pengutronix.de/cgit/barebox/commit/?id=5e86781197ad (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2026-08-28 12:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 11:45 Ahmad Fatoum
2026-08-28 12:14 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178791927279.421663.3598324641369675379.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox