From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: Re: [PATCH 1/2] libfile: advance offset in pread_full() on short reads
Date: Fri, 28 Aug 2026 14:18:09 +0200 [thread overview]
Message-ID: <178791948919.426331.2204410585316458537.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20260826095604.2652204-1-a.fatoum@pengutronix.de>
On Wed, 26 Aug 2026 11:55:37 +0200, Ahmad Fatoum wrote:
> pread_full() loops until the requested size was read, but reads from
> the same offset on every iteration, so a short read is followed by
> re-reading the same data instead of the remainder.
>
> Advance the offset along with the buffer pointer.
>
>
> [...]
Applied, thanks!
[1/2] libfile: advance offset in pread_full() on short reads
https://git.pengutronix.de/cgit/barebox/commit/?id=ab863d035c6d (link may not be stable)
[2/2] libfile: allow fixup_path_case() to resolve directories
https://git.pengutronix.de/cgit/barebox/commit/?id=edf68574ef1f (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2026-08-28 12:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 9:55 Ahmad Fatoum
2026-08-26 9:55 ` [PATCH 2/2] libfile: allow fixup_path_case() to resolve directories Ahmad Fatoum
2026-08-28 12:18 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178791948919.426331.2204410585316458537.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox