From: Sascha Hauer <s.hauer@pengutronix.de>
To: BAREBOX <barebox@lists.infradead.org>,
Sascha Hauer <s.hauer@pengutronix.de>
Subject: Re: [PATCH v2 0/4] fs: return error pointers from ->get_link() on failure
Date: Mon, 02 Nov 2026 14:25:57 +0100 [thread overview]
Message-ID: <179362595779.2747809.17246124292515949563.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20261102-fs-getlink-fixes-v2-0-37df92e4d0d3@pengutronix.de>
On Mon, 02 Nov 2026 10:31:19 +0100, Sascha Hauer wrote:
> Like in Linux, the callers of ->get_link() expect an error pointer when
> the link can't be read: readlinkat() checks the result only with
> IS_ERR() before copying from it, and path lookup takes NULL to mean that
> the link has already been followed and continues from the directory
> containing the link. barebox has no nd_jump_link(), so a NULL from
> ->get_link() is never legitimate there.
>
> [...]
Applied, thanks!
[1/4] fs: cramfs: don't ignore decompression errors
https://git.pengutronix.de/cgit/barebox/commit/?id=f6a16c4da65a (link may not be stable)
[2/4] fs: cramfs: return an error pointer from cramfs_get_link()
https://git.pengutronix.de/cgit/barebox/commit/?id=ec13edfe0bcb (link may not be stable)
[3/4] fs: ext4: return an error pointer from ext_get_link()
https://git.pengutronix.de/cgit/barebox/commit/?id=abf4a2626aec (link may not be stable)
[4/4] fs: legacy: return an error pointer from legacy_get_link()
https://git.pengutronix.de/cgit/barebox/commit/?id=6a8b1f474121 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2026-11-02 13:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 9:31 Sascha Hauer
2026-11-02 9:31 ` [PATCH v2 1/4] fs: cramfs: don't ignore decompression errors Sascha Hauer
2026-11-02 9:34 ` Sascha Hauer
2026-11-02 9:31 ` [PATCH v2 2/4] fs: cramfs: return an error pointer from cramfs_get_link() Sascha Hauer
2026-11-02 9:31 ` [PATCH v2 3/4] fs: ext4: return an error pointer from ext_get_link() Sascha Hauer
2026-11-02 9:31 ` [PATCH v2 4/4] fs: legacy: return an error pointer from legacy_get_link() Sascha Hauer
2026-11-02 13:25 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179362595779.2747809.17246124292515949563.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox