From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>,
Sascha Hauer <s.hauer@pengutronix.de>
Subject: Re: [PATCH 1/2] fs: ubifs: don't free the symlink target twice
Date: Tue, 03 Nov 2026 14:42:10 +0100 [thread overview]
Message-ID: <179371333023.3383937.9268461331664526999.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20261102145302.3025815-1-s.hauer@pengutronix.de>
On Mon, 02 Nov 2026 15:53:01 +0100, Sascha Hauer wrote:
> ubifs_iget() makes ui->data the inode's i_link for symlinks. Since
> commit 66666e887c ("fs: free inode->i_link") the VFS frees i_link when
> destroying an inode, and ubifs_destroy_inode() then frees ui->data
> again. Unmounting a UBIFS that had a symlink looked up thus ends in a
> double free:
>
> !block_is_free(block) && "block already marked as free"common/tlsf.c 1069
> ...
> (ubifs_destroy_inode+0x18/0x2c) from (destroy_inode+0x38/0x4c)
>
> [...]
Applied, thanks!
[1/2] fs: ubifs: don't free the symlink target twice
https://git.pengutronix.de/cgit/barebox/commit/?id=0d77ce844730 (link may not be stable)
[2/2] fs: jffs2: don't free the symlink target twice
https://git.pengutronix.de/cgit/barebox/commit/?id=ba365e56c385 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
next prev parent reply other threads:[~2026-11-03 13:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 14:53 Sascha Hauer
2026-11-02 14:53 ` [PATCH 2/2] fs: jffs2: " Sascha Hauer
2026-11-03 13:42 ` Sascha Hauer [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-11-02 14:52 [PATCH 1/2] fs: ubifs: " Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179371333023.3383937.9268461331664526999.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox