From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@barebox.org>
Subject: Re: [PATCH] commands: go: start files 4 KiB aligned
Date: Mon, 09 Nov 2026 10:00:04 +0100 [thread overview]
Message-ID: <179421480440.492723.16820878652952095553.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20261108201605.1401306-1-a.fatoum@barebox.org>
On Sun, 08 Nov 2026 21:15:42 +0100, Ahmad Fatoum wrote:
> go memmaps the file and jumps to wherever its data happens to be. For a
> file in ramfs, that's a malloc'ed chunk, but barebox on ARM64 addresses
> its data with adrp and needs to run 4 KiB aligned.
>
> Let's read files that can't be memmapped 4 KiB aligned into an aligned
> buffer instead. This also makes go work with files that can't be
> memmapped at all, like those on TFTP.
>
> [...]
Applied, thanks!
[1/1] commands: go: start files 4 KiB aligned
https://git.pengutronix.de/cgit/barebox/commit/?id=7fa5fc73ccf4 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2026-11-09 10:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-08 20:15 Ahmad Fatoum
2026-11-09 9:00 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179421480440.492723.16820878652952095553.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@barebox.org \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox