mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: wodev@progra.biz.pl
To: barebox@lists.infradead.org
Subject: ubiattach reserves too many BEBs for each volume attached
Date: Fri, 11 Feb 2022 16:23:46 +0100	[thread overview]
Message-ID: <1bee39a15fd98b399a28fbf8fed363da@progra.biz.pl> (raw)

If there is more than one volume on the device, ubiattach reserves 
amount of BEBs as for the whole device, each time. Small volumes can be 
covered mainly by reserved blocks on big devices.
With this the amount of BEBs is proportional to the volume size.

---
  drivers/mtd/ubi/build.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c
index 94b4231..54e16f1 100644
--- a/drivers/mtd/ubi/build.c
+++ b/drivers/mtd/ubi/build.c
@@ -237,7 +237,7 @@ static int get_bad_peb_limit(const struct ubi_device 
*ubi, int max_beb_per1024)
  	else
  		device_size = ubi->mtd->size;

-	device_pebs = mtd_div_by_eb(device_size, ubi->mtd);
+	device_pebs = mtd_div_by_eb(ubi->mtd->size, ubi->mtd);
  	limit = mult_frac(device_pebs, max_beb_per1024, 1024);

  	/* Round it up */
-- 
2.35.1

Regards,
Michał

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2022-02-11 15:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-11 15:23 wodev [this message]
2022-02-11 15:36 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1bee39a15fd98b399a28fbf8fed363da@progra.biz.pl \
    --to=wodev@progra.biz.pl \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox