From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: barebox@lists.infradead.org
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
Subject: [PATCH 2/4] net: Adjust net_copy_uint32's signature
Date: Sat, 7 Sep 2019 16:54:54 -0700 [thread overview]
Message-ID: <20190907235456.21535-2-andrew.smirnov@gmail.com> (raw)
In-Reply-To: <20190907235456.21535-1-andrew.smirnov@gmail.com>
Net_copy_uint32() uses memcpy() under the hood, so there's no need to
specify "to" and "from" parameters as uint32_t * and place stricter
alignment requirements than necessary.
GCC9 generates a couple of -Waddress-of-packed-member warnings here
otherwise.
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
include/net.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/net.h b/include/net.h
index 6912a557b5..3491425e09 100644
--- a/include/net.h
+++ b/include/net.h
@@ -315,7 +315,7 @@ static inline void net_copy_ip(void *to, void *from)
}
/* copy ulong */
-static inline void net_copy_uint32(uint32_t *to, uint32_t *from)
+static inline void net_copy_uint32(void *to, void *from)
{
memcpy(to, from, sizeof(uint32_t));
}
--
2.21.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-09-07 23:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-07 23:54 [PATCH 1/4] ratp: Mark struct ratp_bb as packed Andrey Smirnov
2019-09-07 23:54 ` Andrey Smirnov [this message]
2019-09-07 23:54 ` [PATCH 3/4] mtd: ubi: Compile fastmap.c with -Wno-address-of-packed-member Andrey Smirnov
2019-09-09 10:23 ` Sascha Hauer
2019-09-10 4:28 ` Andrey Smirnov
2019-09-12 6:55 ` Sascha Hauer
2019-09-07 23:54 ` [PATCH 4/4] USB: gadget: Compile composite.c " Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190907235456.21535-2-andrew.smirnov@gmail.com \
--to=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox