mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v4 2/2] mci: implement command to switch a mmc device to enhanced mode
Date: Thu, 12 Sep 2019 08:16:17 +0200	[thread overview]
Message-ID: <20190912061617.guwsnwogkiya2y36@pengutronix.de> (raw)
In-Reply-To: <20190909203451.13047-3-u.kleine-koenig@pengutronix.de>

On Mon, Sep 09, 2019 at 10:34:51PM +0200, Uwe Kleine-König wrote:
> +	ret = mci_send_ext_csd(mci, ext_csd);
> +	if (ret) {
> +		printf("Failure to read EXT_CSD register\n");
> +		free(ext_csd);
> +		return ERR_PTR(-EIO);
> +	}
> +
> +	return ext_csd;
> +}
> +
> +/* enh_area -m [-c] /dev/mmcX */

-m is not implemented

> +static int do_mmc_enh_area(int argc, char *argv[])
> +{
> +	const char *devpath;
> +	struct mci *mci;
> +	u8 *ext_csd;
> +	int set_completed = 0;
> +	int opt;
> +	int ret;
> +
> +	while ((opt = getopt(argc, argv, "c")) > 0) {
> +		switch (opt) {
> +		case 'c':
> +			set_completed = 1;
> +			break;
> +		}
> +	}
> +
> +	/*
> +	 * -m is currently mandatory to allow more flexible enhanced area
> +	 * specifications in the future.
> +	 */

-m?

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2019-09-12  6:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-09 20:34 [PATCH v4 0/2] simplify setting enhanced area of mmc devices Uwe Kleine-König
2019-09-09 20:34 ` [PATCH v4 1/2] mci: provide wrapper for mci_get_device_by_name ∘ devpath_to_name Uwe Kleine-König
2019-09-09 20:34 ` [PATCH v4 2/2] mci: implement command to switch a mmc device to enhanced mode Uwe Kleine-König
2019-09-12  6:16   ` Sascha Hauer [this message]
2019-09-12  6:42     ` Uwe Kleine-König
2019-09-12  6:47       ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190912061617.guwsnwogkiya2y36@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox