From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org, Chris Healy <cphealy@gmail.com>
Subject: Re: [PATCH] net: dsa: mv88e6xxx: Wait for EEPROM done after HW reset
Date: Mon, 16 Sep 2019 09:37:59 +0200 [thread overview]
Message-ID: <20190916073759.aoqpmyb7rtgw4ae4@pengutronix.de> (raw)
In-Reply-To: <20190914062424.7919-1-andrew.smirnov@gmail.com>
On Fri, Sep 13, 2019 at 11:24:24PM -0700, Andrey Smirnov wrote:
> Based on a unpublished patch from Andrew Lunn:
>
> The the switch is hardware reset, it reads the contents of the
> EEPROM.
Could you correct this sentence to make its meaning clear?
> This can contain instructions for programming values into
> registers and to perform waits between such programming. Reading
> the EEPROM can take longer than the 100ms
> mv88e6xxx_hardware_reset() waits after deasserting the reset
> GPIO. So poll the EEPROM done bit to ensure it is complete.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
>
> @@ -836,6 +865,11 @@ static int mv88e6xxx_probe(struct device_d *dev)
> */
> mv88e6xxx_hardware_reset_delay();
> }
> + /*
> + * Switch will not retrun valid data over MDIO until EEPROM is
> + * loaded
s/retrun/return/
> + */
> + mv88e6xxx_g1_wait_eeprom_done(chip);
>
> err = mv88e6xxx_detect(chip);
> if (err)
> +void mv88e6xxx_g1_wait_eeprom_done(struct mv88e6xxx_chip *chip)
> +{
> + const uint64_t start = get_time_ns();
> + const uint64_t timeout = 20 * SECOND;
> + u16 val;
> + int err;
> +
> + /* Wait up to 1 second for the switch to finish reading the
> + * EEPROM.
> + */
> + while (!is_timeout(start, timeout)) {
> + err = mv88e6xxx_g1_read(chip, MV88E6XXX_G1_STS, &val);
> + if (err) {
> + dev_err(chip->dev, "Error reading status");
> + return;
> + }
> +
> + if (val != 0xFFFF && /* switch will return 0xffff it it */
This comment looks incomplete.
> + val & BIT(MV88E6XXX_G1_STS_IRQ_EEPROM_DONE))
> + return;
> +
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-09-16 7:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-14 6:24 Andrey Smirnov
2019-09-16 7:37 ` Sascha Hauer [this message]
2019-09-23 17:50 ` Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190916073759.aoqpmyb7rtgw4ae4@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=cphealy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox