From: Michael Grzeschik <mgr@pengutronix.de>
To: barebox@lists.infradead.org
Subject: Re: [PATCH 1/5] net: cpsw: fix cpsw_slave_regs register offsets
Date: Tue, 5 May 2020 11:09:23 +0200 [thread overview]
Message-ID: <20200505090923.GO7200@pengutronix.de> (raw)
In-Reply-To: <20200504075022.28234-2-m.grzeschik@pengutronix.de>
[-- Attachment #1.1: Type: text/plain, Size: 1615 bytes --]
I forgot something.
On Mon, May 04, 2020 at 09:50:18AM +0200, Michael Grzeschik wrote:
>The cpsw_slave_regs struct also start with max_blks register, so here we
>also have to skip the first two bytes like for .host_port_reg_ofs
Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
>---
> drivers/net/cpsw.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/cpsw.c b/drivers/net/cpsw.c
>index c3cc43cc5b..d745737aa3 100644
>--- a/drivers/net/cpsw.c
>+++ b/drivers/net/cpsw.c
>@@ -1015,7 +1015,7 @@ static struct cpsw_data cpsw1_data = {
> .cpdma_reg_ofs = 0x100,
> .state_ram_ofs = 0x200,
> .ale_reg_ofs = 0x600,
>- .slave_ofs = 0x050,
>+ .slave_ofs = 0x058,
> .slave_size = 0x040,
> .sliver_ofs = 0x700,
> /* FIXME: mdio_reg_ofs and cppi_ram_ofs missing */
>@@ -1026,7 +1026,7 @@ static struct cpsw_data cpsw2_data = {
> .cpdma_reg_ofs = 0x800,
> .state_ram_ofs = 0xa00,
> .ale_reg_ofs = 0xd00,
>- .slave_ofs = 0x200,
>+ .slave_ofs = 0x208,
> .slave_size = 0x100,
> .sliver_ofs = 0xd80,
> .mdio_reg_ofs = 0x1000,
>--
>2.26.2
>
>
>_______________________________________________
>barebox mailing list
>barebox@lists.infradead.org
>http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 149 bytes --]
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-05-05 9:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 7:50 [PATCH 0/5] net: cpsw: dual_emac mode Michael Grzeschik
2020-05-04 7:50 ` [PATCH 1/5] net: cpsw: fix cpsw_slave_regs register offsets Michael Grzeschik
2020-05-05 9:09 ` Michael Grzeschik [this message]
2020-05-04 7:50 ` [PATCH 2/5] net: cpsw: move generic setup code to probe Michael Grzeschik
2020-05-04 7:50 ` [PATCH 3/5] net: cpsw: cpsw_process should only handle rx channels for its own port Michael Grzeschik
2020-05-04 7:50 ` [PATCH 4/5] net: cpsw: add vlan handling for dual_emac mode Michael Grzeschik
2020-05-04 7:50 ` [PATCH 5/5] net: cpsw: make cpsw_send directional Michael Grzeschik
2020-05-05 10:22 ` [PATCH 0/5] net: cpsw: dual_emac mode Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200505090923.GO7200@pengutronix.de \
--to=mgr@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox