mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH 22/23] sandbox: os: add_image: fix memory leak
Date: Mon, 11 May 2020 09:21:39 +0200	[thread overview]
Message-ID: <20200511072140.29610-23-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20200511072140.29610-1-a.fatoum@pengutronix.de>

devname is strdup'd few lines later, so remove the earlier strdup.
The pointer isn't stored anywhere persistent in between.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 arch/sandbox/os/common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/sandbox/os/common.c b/arch/sandbox/os/common.c
index e67ea14138c0..382a92304020 100644
--- a/arch/sandbox/os/common.c
+++ b/arch/sandbox/os/common.c
@@ -236,7 +236,7 @@ static int add_image(char *str, char *devname_template, int *devname_number)
 		filename = devname;
 		snprintf(tmp, sizeof(tmp),
 			 devname_template, (*devname_number)++);
-		devname = strdup(tmp);
+		devname = tmp;
 	}
 
 	printf("add %s backed by file %s%s\n", devname,
-- 
2.26.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2020-05-11  7:21 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-11  7:21 [PATCH 00/23] sandbox: support COMPILE_TESTing drivers Ahmad Fatoum
2020-05-11  7:21 ` [PATCH 01/23] scripts: import Linux Kconfig.include Ahmad Fatoum
2020-05-11  7:21 ` [PATCH 02/23] sandbox: define CONFIG_64BIT as appropriate Ahmad Fatoum
2020-05-11 10:00   ` Roland Hieber
2020-05-12  7:14     ` Ahmad Fatoum
2020-05-11  7:21 ` [PATCH 03/23] sandbox: asm: bitsperlong.h: detect bitness according to 64BIT symbol Ahmad Fatoum
2020-05-11  7:21 ` [PATCH 04/23] include: io.h: provide (in|out)_(le|be)(16|32) helpers for all archs Ahmad Fatoum
2020-05-12  7:11   ` Sascha Hauer
2020-05-12  7:13     ` Ahmad Fatoum
2020-05-11  7:21 ` [PATCH 05/23] ARM: asm/io.h: fall back to asm-generic out_be32 and friends Ahmad Fatoum
2020-05-11  7:21 ` [PATCH 06/23] clocksource: arm_global_timer.c: remove unused asm/ header Ahmad Fatoum
2020-05-11  7:21 ` [PATCH 07/23] mtd: nand: orion: depend on ARM Ahmad Fatoum
2020-05-11  7:21 ` [PATCH 08/23] ddr: fsl: " Ahmad Fatoum
2020-05-11  7:21 ` [PATCH 09/23] net: fec_imx: depend on HAS_DMA Ahmad Fatoum
2020-05-11  7:21 ` [PATCH 10/23] net: macb: " Ahmad Fatoum
2020-05-11  7:21 ` [PATCH 11/23] sandbox: implement stub physical virtual translation Ahmad Fatoum
2020-05-11  7:21 ` [PATCH 12/23] sandbox: asm: implement stub DMA functions Ahmad Fatoum
2020-05-11  7:21 ` [PATCH 13/23] sandbox: select HAS_DMA Ahmad Fatoum
2020-05-11  7:21 ` [PATCH 14/23] ARM: atomic.h: move generic implementation to asm-generic Ahmad Fatoum
2020-05-11  7:21 ` [PATCH 15/23] sandbox: asm: implement <asm/atomic.h> Ahmad Fatoum
2020-05-12  7:26   ` Sascha Hauer
2020-05-11  7:21 ` [PATCH 16/23] sandbox: support forcing 32-bit x86 Ahmad Fatoum
2020-05-11  7:21 ` [PATCH 17/23] usb: xhci-hcd: remove unused #include <asm/cache.h> Ahmad Fatoum
2020-05-11  7:21 ` [PATCH 18/23] usb: xhci-hcd: replace opencoded non-atomic 64-bit MMIO with lo_hi helper Ahmad Fatoum
2020-05-11  7:21 ` [PATCH 19/23] include: bitops: fix dead increment in fls() and ffs() Ahmad Fatoum
2020-05-12  7:31   ` Sascha Hauer
2020-05-11  7:21 ` [PATCH 20/23] commands: tftp: drop unused variable Ahmad Fatoum
2020-05-11  7:21 ` [PATCH 21/23] commands: test: drop dead assignment Ahmad Fatoum
2020-05-11  7:21 ` Ahmad Fatoum [this message]
2020-05-11  7:21 ` [PATCH 23/23] mtd: nand: base: fix use of uninitialized struct member Ahmad Fatoum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200511072140.29610-23-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox