From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH] startup: Fix do_autoboot_countdown() running multiple times
Date: Wed, 1 Jul 2020 07:26:42 +0200 [thread overview]
Message-ID: <20200701052642.GI15485@pengutronix.de> (raw)
In-Reply-To: <fa8c9ed1-8cde-a015-86ee-10c86ff65bbf@pengutronix.de>
On Mon, Jun 29, 2020 at 10:37:43AM +0200, Ahmad Fatoum wrote:
> Hi,
>
> On 6/26/20 8:41 AM, Sascha Hauer wrote:
> > The comment above do_autoboot_countdown() states: "This function can be
> > called multiple times, it is executed only the first time.". Since
> > 1973892533 ("startup: don't clobber original autoboot state") This is no
> > longer the case. Bring back the old and documented behaviour.
>
> guilty as charged. I didn't read the comment..
> do_autoboot_countdown is called only once though in the code base.
> How do you make use of being able to call it multiple times?
We use this in a customer project. The decision whether we want to abort
boot or not has to be made earlier. That said, it's out of tree code, so
should this hurt anywhere else, we can change it and find another
solution for our customer.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2020-07-01 5:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 6:41 Sascha Hauer
2020-06-29 8:37 ` Ahmad Fatoum
2020-07-01 5:26 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200701052642.GI15485@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox