mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] mfd: superio: smsc: fix C99ism initial declaration in for loop
Date: Sun, 5 Jul 2020 16:21:04 +0200	[thread overview]
Message-ID: <20200705142104.GV15485@pengutronix.de> (raw)
In-Reply-To: <20200702132919.22009-1-a.fatoum@pengutronix.de>

On Thu, Jul 02, 2020 at 03:29:18PM +0200, Ahmad Fatoum wrote:
> Codebase is meant to be gnu89, but was only enforced starting
> with bc4840e98b94 ("kbuild: add -Wmissing-prototypes and -std=gnu89
> to KBUILD_HOSTCFLAGS"). Since then, this driver no longer compiles.
> Fix this.
> 
> Fixes: eaf020f1bb52 ("mfd: superio: add base SMSC MFD driver")
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  drivers/mfd/smsc-superio.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/mfd/smsc-superio.c b/drivers/mfd/smsc-superio.c
> index 349c878cefe0..ff83aa1a4419 100644
> --- a/drivers/mfd/smsc-superio.c
> +++ b/drivers/mfd/smsc-superio.c
> @@ -106,8 +106,9 @@ static void smsc_superio_find(u16 sioaddr, u16 id_reg)
>  static int smsc_superio_detect(void)
>  {
>  	u16 ports[] = { 0x2e, 0x4e, 0x162e, 0x164e, 0x3f0, 0x370 };
> +	int i;
>  
> -	for (int i = 0; i < ARRAY_SIZE(ports); i++)
> +	for (i = 0; i < ARRAY_SIZE(ports); i++)
>  		smsc_superio_find(ports[i], SIO_REG_DEVID);
>  
>  	return 0;
> -- 
> 2.27.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      parent reply	other threads:[~2020-07-05 14:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-02 13:29 Ahmad Fatoum
2020-07-02 13:29 ` [PATCH 2/2] mfd: superio: depend on X86 || COMPILE_TEST Ahmad Fatoum
2020-07-05 14:21 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200705142104.GV15485@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox