From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org, Juergen Borleis <jbe@pengutronix.de>
Subject: Re: [PATCH 3/5] mci: mci-core: fix long lasting FIXMEs
Date: Mon, 14 Sep 2020 20:02:54 +0200 [thread overview]
Message-ID: <20200914180254.GY4498@pengutronix.de> (raw)
In-Reply-To: <e7db4a95-5665-2d86-0450-3cfd56ec477a@pengutronix.de>
On Mon, Sep 14, 2020 at 04:58:01PM +0200, Ahmad Fatoum wrote:
> Hello Juergen,
>
> On 9/9/20 1:01 PM, Juergen Borleis wrote:
> > Signed-off-by: Juergen Borleis <jbe@pengutronix.de>
> > ---
> > drivers/mci/mci-core.c | 22 +++++++++++++---------
> > 1 file changed, 13 insertions(+), 9 deletions(-)
> >
> > diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c
> > index a58dedc1cd..d93be6d33f 100644
> > --- a/drivers/mci/mci-core.c
> > +++ b/drivers/mci/mci-core.c
> > @@ -361,9 +361,9 @@ static int mmc_send_op_cond(struct mci *mci)
> > }
> >
> > /**
> > - * FIXME
> > - * @param mci MCI instance
> > - * @param ext_csd Buffer for a 512 byte sized extended CSD
> > + * Read-in the card's whole extended CSD configuration area
> > + * @param[in] mci MCI instance
> > + * @param[out] ext_csd Buffer for an #EXT_CSD_BLOCKSIZE byte sized extended CSD
> > * @return Transaction status (0 on success)
> > *
> > * Note: Only cards newer than Version 1.1 (Physical Layer Spec) support
> > @@ -379,19 +379,23 @@ int mci_send_ext_csd(struct mci *mci, char *ext_csd)
> >
> > data.dest = ext_csd;
> > data.blocks = 1;
> > - data.blocksize = 512;
> > + data.blocksize = EXT_CSD_BLOCKSIZE;
>
> This breaks the build; EXT_CSD_BLOCKSIZE is undeclared in mci-core.c.
> Did you forget a prerequisite patch?
Dropped the patch for now.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-09-14 18:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 11:01 [PATCH 1/5] commands: mmc_extcsd: print_field: fix 32 bit overflow Juergen Borleis
2020-09-09 11:01 ` [PATCH 2/5] commands: mmc_extcsd: print_field: fix layout Juergen Borleis
2020-09-09 11:01 ` [PATCH 3/5] mci: mci-core: fix long lasting FIXMEs Juergen Borleis
2020-09-14 14:58 ` Ahmad Fatoum
2020-09-14 18:02 ` Sascha Hauer [this message]
2020-09-15 7:45 ` Juergen Borleis
2020-09-15 7:52 ` [PATCH v2] " Juergen Borleis
2020-09-15 12:36 ` Sascha Hauer
2020-09-09 11:01 ` [PATCH 4/5] mci: kconfig: explain what boot partitions are Juergen Borleis
2020-09-09 11:01 ` [PATCH 5/5] mci: mci-core: add GPP support Juergen Borleis
2020-09-14 10:07 ` [PATCH 1/5] commands: mmc_extcsd: print_field: fix 32 bit overflow Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200914180254.GY4498@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=jbe@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox